Skip to content

ci(FR-2791): add backend.ai-client lint/typecheck/test/build workflow#7203

Open
yomybaby wants to merge 1 commit intomainfrom
04-30-ci_fr-2791_add_backend.ai-client_lint_typecheck_test_build_workflow
Open

ci(FR-2791): add backend.ai-client lint/typecheck/test/build workflow#7203
yomybaby wants to merge 1 commit intomainfrom
04-30-ci_fr-2791_add_backend.ai-client_lint_typecheck_test_build_workflow

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented Apr 30, 2026

Resolves #7198(FR-2791)

Epic: FR-2792 (backend.ai-client production readiness)

Summary

Adds a dedicated GitHub Actions workflow that validates packages/backend.ai-client on PRs and on main pushes. The repo's existing scripts/verify.sh only covers the React app, so library-only regressions (lint, typecheck, test, build) currently slip through.

Workflow

.github/workflows/backend-ai-client-ci.yml runs on PRs and pushes that touch the package or the lockfile, and executes:

  1. pnpm install --merge-git-branch-lockfiles --no-frozen-lockfile (matches the vitest.yml pattern; the repo uses gitBranchLockfile: true)
  2. pnpm --filter backend.ai-client run lint
  3. pnpm --filter backend.ai-client exec tsc --noEmit
  4. pnpm --filter backend.ai-client run test
  5. pnpm --filter backend.ai-client run build

Path filter covers packages/backend.ai-client/**, pnpm-lock.yaml, and the workflow file itself; concurrency is set to cancel in-flight runs of the same head ref.

Soft dependency

The lint step depends on FR-2790 / #7204 landing first (that PR adds eslint.config.js). Both PRs are in the same Epic FR-2792 and intended to merge together; CI will be green on main after both land.

Out of scope

  • npm publish workflow — separate ticket once a publishing strategy is decided.
  • Coverage thresholds — separate ticket once additional unit tests land.
  • Branch protection / required-check enforcement — left to the maintainer.

Verification

  • YAML parses (python3 -c "yaml.safe_load(...)").
  • All step commands run green locally on the merged-Epic state (lint 0 errors / 242 warnings, typecheck pass, tests 4/4 pass, build success).
  • Action and pnpm versions (actions/checkout@v5, pnpm/action-setup@v5, actions/setup-node@v5, actions/cache@v5) match what's already used by vitest.yml and publish-backend.ai-ui.yml.

@github-actions github-actions Bot added the size:M 30~100 LoC label Apr 30, 2026
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review April 30, 2026 16:25
Copilot AI review requested due to automatic review settings April 30, 2026 16:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated GitHub Actions workflow to validate the packages/backend.ai-client workspace package on PRs and on pushes to main, aligning the monorepo with package-scoped CI checks.

Changes:

  • Introduces .github/workflows/backend-ai-client-ci.yml to run lint, TypeScript typecheck, tests, and build for backend.ai-client.
  • Adds path-based triggers and concurrency cancellation to avoid redundant runs.

Comment thread .github/workflows/backend-ai-client-ci.yml
Comment thread .github/workflows/backend-ai-client-ci.yml
Comment thread .github/workflows/backend-ai-client-ci.yml Outdated
@yomybaby yomybaby force-pushed the 04-30-ci_fr-2791_add_backend.ai-client_lint_typecheck_test_build_workflow branch from eb50c51 to 4586d75 Compare April 30, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI workflow for backend.ai-client package

2 participants