Skip to content

feature: host networking container#838

Merged
adrysn merged 19 commits intomainfrom
feature/container-host-network
Nov 26, 2022
Merged

feature: host networking container#838
adrysn merged 19 commits intomainfrom
feature/container-host-network

Conversation

@kyujin-cho
Copy link
Copy Markdown
Member

@kyujin-cho kyujin-cho commented Oct 25, 2022 •
edited
Loading

This PR adds support for running Backend.AI Kernel containers on host networking mode.

@github-actions github-actions Bot added the comp:manager Related to Manager component label Oct 25, 2022
@kyujin-cho kyujin-cho requested review from achimnol and adrysn and removed request for achimnol October 25, 2022 14:07
@kyujin-cho kyujin-cho marked this pull request as ready for review October 25, 2022 14:07
@kyujin-cho kyujin-cho added require:db-migration Automatically set when alembic migrations are added or updated comp:agent Related to Agent component labels Oct 26, 2022
achimnol
achimnol reviewed Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achimnol achimnol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments:

  • If you replace the local input handler with /tmp/bai-user-input.sock, libbaihook should be also updated. Please link this PR from there.
  • use_host_network should be configurable by individual agents scaling groups, instead of by manager's local config, I think.

@kyujin-cho kyujin-cho requested a review from achimnol October 28, 2022 07:33
@kyujin-cho
Copy link
Copy Markdown
Member Author

kyujin-cho commented Oct 28, 2022

Created corresponding PR on lablup/backend.ai-hook#4.

@achimnol achimnol added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Nov 2, 2022
achimnol
achimnol requested changes Nov 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix up relatively minor code-level issues.
The overall implementation looks good!

Comment thread src/ai/backend/agent/server.py Outdated
Comment thread src/ai/backend/kernel/base.py Outdated
Comment thread src/ai/backend/agent/agent.py Outdated
Comment thread src/ai/backend/agent/agent.py Outdated
Comment thread src/ai/backend/agent/agent.py Outdated
Comment thread src/ai/backend/agent/agent.py Outdated
Comment thread src/ai/backend/agent/docker/agent.py Outdated
Comment thread src/ai/backend/agent/docker/agent.py Outdated
Comment thread src/ai/backend/manager/config.py Outdated
@kyujin-cho kyujin-cho requested a review from achimnol November 8, 2022 18:02
adrysn
adrysn approved these changes Nov 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrysn adrysn merged commit 848d82a into main Nov 26, 2022
@adrysn adrysn deleted the feature/container-host-network branch November 26, 2022 13:26
This was referenced Nov 30, 2022
Merged
Merged
Open
@agatha197 agatha197 mentioned this pull request Dec 21, 2022
Merged
@Yaminyam Yaminyam added the size:XL 500~ LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrysn adrysn adrysn approved these changes

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@kyujin-cho kyujin-cho

Labels

comp:agent Related to Agent component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XL 500~ LoC urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyujin-cho @achimnol @adrysn @Yaminyam