Skip to content

ci: fix the index spec path in CODEOWNERS - #9360

Open
dajiaohuang wants to merge 1 commit into
lance-format:mainfrom
dajiaohuang:fix/codeowners-index-spec-path
Open

dajiaohuang wants to merge 1 commit into
lance-format:mainfrom
dajiaohuang:fix/codeowners-index-spec-path

Conversation

@dajiaohuang

Copy link
Copy Markdown

The index specification moved from docs/src/format/table/index/ to
docs/src/format/index/, but this CODEOWNERS entry still named the old path,
so it matched no tracked file. The 21 files under docs/src/format/index/
were left without a review request, unlike the file and table specs, whose
patterns still resolve.

$ git ls-tree -r --name-only HEAD -- docs/src/format/table/index/ | wc -l
0
$ git ls-tree -r --name-only HEAD -- docs/src/format/index/ | wc -l
21

The other patterns are unaffected: protos/index.proto and
protos/index_old.proto still exist, and docs/src/format/file/ (4 paths)
and docs/src/format/table/ (10 paths) still resolve.

Checked: every pattern in the file now matches at least one tracked path, and
the typos pre-commit hook passes on the changed file. The change touches no
Rust or Python surface, so no language lint applies.

The index specification moved from docs/src/format/table/index/ to
docs/src/format/index/ when the specs were split, but the CODEOWNERS
entry still named the old path. It matched no tracked file, so the
index spec docs were left without a review request, unlike the file
and table specs.
@github-actions github-actions Bot added A-ci CI / build workflows ci Github Action or Test issues labels Sep 17, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: request changes.

The direct path correction is the right mechanism, but GitHub still rejects the index owner, so this revision cannot deliver the spec-review contract established in #5858. Use a repository-valid owner on this rule and verify that GitHub reports no CODEOWNERS error for it.

Comment thread .github/CODEOWNERS
protos/index.proto @index-spec-team
protos/index_old.proto @index-spec-team
docs/src/format/table/index/ @index-spec-team
docs/src/format/index/ @index-spec-team

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub still reports this changed rule as Unknown owner, so no review request will be sent for the 21 index-spec paths even though the path now matches. Point the rule at an owner GitHub accepts for this repository (for example, the intended organization/team slug if that team exists and has write access), then verify this line disappears from the CODEOWNERS error report.

Reproducer
gh api --method GET repos/lance-format/lance/codeowners/errors \
  -f ref=d981fd51e45223fc3833f92fcfef22afb5eba50e \
  --jq '.errors[] | select(.line == 14) | {line, kind, source}'

Observed:

{"kind":"Unknown owner","line":14,"source":"docs/src/format/index/ @index-spec-team\n"}

Expected: no error for line 14.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Sep 17, 2026
@dajiaohuang

Copy link
Copy Markdown
Author

I checked the live CODEOWNERS validation for commit d981fd5. GitHub reports Unknown owner for @file-spec-team, @table-spec-team, and @index-spec-team (including the corrected docs/src/format/table/index/ rule), so the remaining blocker is the owner identities rather than the path. I do not have org-admin/team visibility to choose a repository-valid replacement. Please provide the valid team or maintainer username for the index-spec rule and I can update the PR.

@lance-gatekeeper lance-gatekeeper Bot removed the K-changes Latest Gatekeeper recommendation requests changes. label Sep 18, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: request changes.

The author’s follow-up confirms the validator result and clarifies that selecting a repository-valid index owner requires maintainer input. The path correction is still right, but the spec-review contract established in #5858 remains unmet until a maintainer identifies the intended writable team or user and the changed rule is updated so GitHub reports no CODEOWNERS error.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci CI / build workflows ci Github Action or Test issues K-changes Latest Gatekeeper recommendation requests changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant