Skip to content

ci: fix the index spec path in CODEOWNERS #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: fix the index spec path in CODEOWNERS #9360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ docs/src/format/table/ @table-spec-team
# index specification
protos/index.proto @index-spec-team
protos/index_old.proto @index-spec-team
docs/src/format/table/index/ @index-spec-team
docs/src/format/index/ @index-spec-team

@lance-gatekeeper lance-gatekeeper Bot Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub still reports this changed rule as Unknown owner, so no review request will be sent for the 21 index-spec paths even though the path now matches. Point the rule at an owner GitHub accepts for this repository (for example, the intended organization/team slug if that team exists and has write access), then verify this line disappears from the CODEOWNERS error report.

Reproducer 
gh api --method GET repos/lance-format/lance/codeowners/errors \
  -f ref=d981fd51e45223fc3833f92fcfef22afb5eba50e \
  --jq '.errors[] | select(.line == 14) | {line, kind, source}'

Observed:

{"kind":"Unknown owner","line":14,"source":"docs/src/format/index/ @index-spec-team\n"}

Expected: no error for line 14.

Loading