Add Ember Dark to the public site - #217
Conversation
Work intentphase: review
summary: "Implementation, automated checks, and owner desktop/narrow Ember Dark QA are complete."
touch-points:
- docs/user/*.html
- docs/user/*/index.html
- docs/user/styles.css
- docs/user/site.ts
- test/docs-site.test.ts
done-when:
- "All seven Pages documents resolve system or persisted light/dark appearance before CSS."
- "Dark appearance uses the effective in-app Ember Dark low-colorization surfaces, a visible public rule, and unchanged canonical brand assets."
- "Accessible day/night controls synchronize state and browser theme color."
- "Desktop and 320px layouts have no horizontal overflow in both appearances."
- "Screenshots, movie, poster, README, and social cards remain Ember Light assets."
- "Focused tests, full ci:local, GitHub CI, and owner light/dark visual QA pass."
excludes:
- "Product theme changes or new product captures."
- "Recoloring README, screenshots, movie, poster, or social cards."
- "Launch-copy editing, Fable review, announcements, and repository settings."
blocked-by:
- "#214"
may-block:
- "#205"
branch: "t3code/public-ember-dark"Completion: Completed after three finding-bearing exact-head review rounds. Final head d62862a passed 934 tests and the packaged smoke test; it was squash-merged as b67b949. The accessible alternate palette remains preserved separately in comment 5465177067 for future theme exploration. |
Future theme seed — adapted editorial dark (not shipping in #217)Owner QA rejected this palette as Ember Dark because it is an adapted public-site theme rather than the in-app product theme, but liked it enough to preserve for possible future theme work. Exact seed from commit --brand-orange: #e5b8a8;
--brand-burgundy: #e5b8a8;
--ink: #dfdedd;
--muted: #aaa8a6;
--ground: #242221;
--paper: #161514;
--neutral-soft: #110e0a;
--surface: #0b0808;
--line: #4a3a34;
--brand-soft: #2b2422;
--code: #0e0e0e;The distinguishing choices are the pale rose accent/link alias, stronger warm rule, and pale recolored brand artwork. If promoted later, it should receive its own name, product-theme decision, and accessibility/visual QA rather than being described as Ember Dark. |
36066b9 to
6c1a07f
Compare
320d13f to
34695d3
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34695d3fe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a03edff6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 090eb589d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-project-automation
Bot
moved this from In Progress
to Done
in Markover Announcement Readiness
* add Ember Dark public appearance * match public dark mode to Ember Dark * refine the public site at phone widths * stabilize the responsive footer * keep dark accents readable * keep dark button borders semantic * keep dark dialog and sidebar controls usable * collapse public navigation before controls crowd
* docs: plan Ember Light visual refresh * docs: align visual refresh plan with design brief * Stage sanitized public capture state (#210) * docs: define public capture contract * feat: stage sanitized public capture state * test: satisfy capture staging quality gates * Restyle public surfaces for Ember Light (#212) * style: align public tokens with Ember Light * docs: redraw current public product surfaces * use canonical public app branding * Recapture the current Ember Light product UI (#213) * docs: reserve one strongest product capture * docs: automate current product stills * fix: target the packaged capture renderer * fix: settle captures after hidden toasts * docs: replace product captures with Ember Light * fix: retain capture provenance after restack * Publish the preview demo and launch assets (#214) * chore: start demo and launch assets slice * docs: automate the focused preview demo * docs: show opening the captured review * docs: publish the focused preview demo * docs: finish the focused preview launch assets * test: tighten launch asset assertions * polish public preview typography * fix: retain demo capture provenance after restack * fix: identify Claude Code host examples * fix: use accessible public counter color * fix: reserve Ember orange for non-text accents * fix: carry preview boundary on demo end card * fix: activate unrecorded demo setup directly * docs: regenerate demo with preview boundary * Add Ember Dark to the public site (#217) * add Ember Dark public appearance * match public dark mode to Ember Dark * refine the public site at phone widths * stabilize the responsive footer * keep dark accents readable * keep dark button borders semantic * keep dark dialog and sidebar controls usable * collapse public navigation before controls crowd * Polish focused-preview public copy (#220) * polish public preview copy * align public copy assertions * restore canonical and pane terminology * keep agent and privacy copy contract-accurate * narrow every local-data promise * Stabilize public heading typography (#221) * stabilize the public hero heading * smooth the hero type breakpoint * restore lighter public heading weights * recapture stills from a retained source * recapture demo from a retained source * keep brand assets legible in Ember Dark * keep the mobile disclosure readable
1 participant
Outcome
Adds a system-aware, persistent Ember Dark appearance to every GitHub Pages document while preserving Ember Light as the published product-media and social-card capture theme.
Stack
t3code/demo-launch-assets)mainafter this child and its prerequisites are accepted.Included
Boundary
This PR changes only the GitHub Pages appearance. It does not recolor or recapture screenshots, movie, poster, README, or social cards; change product themes; edit launch copy; or resolve the later Fable/content review. The earlier rose-tinted public-dark exploration is preserved only as a future-theme seed in this PR comment; none of those adapted colors ship here.
Evidence
npm run ci:local: 933/933 tests, lint, typecheck, notices, and native smoke passed at commit61cb225.320d13f.320d13f.