feat: propagate FDv1 fallback directive from FDv2 polling and streaming sources#538
Open
beekld wants to merge 4 commits into
Open
feat: propagate FDv1 fallback directive from FDv2 polling and streaming sources#538beekld wants to merge 4 commits into
beekld wants to merge 4 commits into
Conversation
3 tasks
d795752 to
12b23ec
Compare
762768c to
57d4dfb
Compare
57d4dfb to
c95b74a
Compare
…esWithCustomHeader test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each FDv2 source now inspects the
X-LD-FD-Fallbackresponse header (value"true", case-insensitive) and stampsFDv2SourceResult.fdv1_fallbackon every emitted result. The orchestrator does not yet consume the flag — that comes in a follow-up.Design notes
fdv1_fallbackis hoisted from per-variant (was onChangeSet,Interrupted,TerminalError,Goodbye) to a top-level field onFDv2SourceResult. The flag is a property of the HTTP response, not of the result kind. Touches every existing construction site (mechanical: drop trailingfalsearg, the top-level default does the rest).latest_fdv1_fallback_bool onState. EachOnResponseoverwrites it from the incoming headers, so a fresh response without the directive clears it. Events between two responses share the flag from the most recent response.Test plan
fdv2_polling_impl_test.cppcovers propagation across all variants + value comparisonNote
Medium Risk
Changes the FDv2 source result contract and how sync responses are interpreted ahead of orchestrator fallback logic; mistakes could mis-signal FDv1 downgrade, but behavior is not yet wired to switching data modes.
Overview
FDv2 sources now surface a server-driven FDv1 fallback signal on every
FDv2SourceResult. Thefdv1_fallbackflag moves from nested variant payloads to a single top-level field (defaultfalse), reflecting that it comes from the HTTP response, not the result kind.Polling reads
X-LD-FD-Fallback(valuetrue, case-insensitive) from poll HTTP headers and setsfdv1_fallbackon 304/200 outcomes and HTTP error paths; transport-level failures without a response still leave it false.Streaming registers an SSE
on_responsehook, keepslatest_fdv1_fallback_from the most recent response headers (cleared when a later response omits the header), and applies it inNotifyto all delivered results—including errors after a directive.Tests were updated for the new shape; new coverage exercises polling and streaming propagation. Orchestrator behavior is unchanged in this PR—the flag is stamped only for a follow-up to consume.
Reviewed by Cursor Bugbot for commit 8e354cd. Bugbot is set up for automated code reviews on this repo. Configure here.