feat: orchestrator switches to FDv1 fallback on directive#539
Draft
beekld wants to merge 1 commit into
Draft
Conversation
2 tasks
beekld
force-pushed
the
beeklimt/SDK-2379-2
branch
from
1833a9c to
d795752
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
from
9f04fa3 to
ea3b92b
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-2
branch
from
d795752 to
12b23ec
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
from
ea3b92b to
142b2ff
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-2
branch
from
12b23ec to
96a7f5a
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
3 times, most recently
from
e2824ec to
f0b2aab
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-2
branch
from
762768c to
57d4dfb
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
from
f0b2aab to
f94ce01
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-2
branch
from
57d4dfb to
c95b74a
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
from
f94ce01 to
eb28df0
Compare
beekld
force-pushed
the
beeklimt/SDK-2379-3
branch
from
eb28df0 to
3e76ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #538. The orchestrator now reacts to
FDv2SourceResult.fdv1_fallback: it logs the directive at info level, callsSourceManager::SwitchToFDv1Fallback(), and advances to the FDv1 adapter (or transitions to OFF if no adapter is configured).End-to-end fallback will work once an FDv1 streaming source is wrapped as an
IFDv2Synchronizer(separate PR).Test plan
SourceManagertests cover the start-blocked behavior,SwitchToFDv1Fallback()block/unblock semantics, and the no-adapter case