feat: use only one animation flush and and only in case of existing masks#191
Merged
Conversation
Vadman97
approved these changes
Apr 27, 2026
abelonogov-ld
pushed a commit
that referenced
this pull request
May 23, 2026
🤖 I have created a release *beep* *boop* --- ## [0.35.0](0.34.1...0.35.0) (2026-05-23) ### Features * use only one animation flush and and only in case of existing masks ([#191](#191)) ([2a09883](2a09883)) ### Bug Fixes * iOS26 SwiftUI masking cases ([#195](#195)) ([386d0ad](386d0ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATransaction.flush() works, but it forces synchronous compositor work on the main thread. PR reduces load of main thread by using only one call in masking and only when masks are present
Note
Medium Risk
Touches the session replay capture/masking pipeline; conditionalizing
CATransaction.flush()could affect mask alignment/timing and thus privacy masking correctness if assumptions are wrong.Overview
Reduces main-thread compositor work during session replay capture by removing the unconditional
CATransaction.flush()and only flushing when the pre-capture mask scan finds at least one mask to apply.Updates the test app menu so the "One TextField" session replay row is wrapped with
.ldMask()(plus a tiny layout/formatting tweak in the button row).Reviewed by Cursor Bugbot for commit 1b143c4. Bugbot is set up for automated code reviews on this repo. Configure here.