Skip to content

feat: use only one animation flush and and only in case of existing masks #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 2 commits into from
May 23, 2026
Merged

feat: use only one animation flush and and only in case of existing masks #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4105c1d
use only one flush and and only in case of existing masks
abelonogov-ld Apr 24, 2026
1b143c4
Merge branch 'main' into andrey/flush-optimization
abelonogov-ld May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sources/LaunchDarklySessionReplay/ScreenCapture/ImageCaptureService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public final class ImageCaptureService {
let enclosingBounds = windowCaptureManager.minimalBoundsEnclosingWindows(windows)
let renderer = windowCaptureManager.makeRenderer(size: enclosingBounds.size, scale: scale)

CATransaction.flush()
let maskOperationsBefore = windows.map { maskCollector.collectViewMasks(in: $0, window: $0, scale: scale) }
let image = renderer.image { ctx in
windowCaptureManager.drawWindows(windows, into: ctx.cgContext, bounds: enclosingBounds, afterScreenUpdates: false)
Expand All @@ -64,8 +63,12 @@ public final class ImageCaptureService {
DispatchQueue.main.async { [weak self, weak maskCollector] in
// Move collecting masks after to the next tick
guard let self, let maskCollector, shouldCapture else { return }

let hasMasks = maskOperationsBefore.contains(where: { !$0.maskOperations.isEmpty })
if (hasMasks) {
CATransaction.flush()
}

CATransaction.flush()
let maskOperationsAfter = windows.map { maskCollector.collectViewMasks(in: $0, window: $0, scale: self.scale) }

Task {
Expand Down
4 changes: 3 additions & 1 deletion TestApp/Sources/MainMenuView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ struct MainMenuView: View {
Section {
MaskingGridRow(title: "One TextField", uikitAction: {
isMaskingUIKitOneFieldEnabled = true
}, swiftUIAction: nil)
}, swiftUIAction: nil).ldMask()

#if os(iOS)
MaskingGridRow(title: "Credit Card", uikitAction: {
isMaskingUIKitCreditCardEnabled = true
Expand Down Expand Up @@ -146,6 +147,7 @@ struct MainMenuView: View {
isNotebookEnabled = true
}
.buttonStyle(.borderedProminent)

Button("Storyboard") {
isStoryboardEnabled = true
}
Expand Down
Loading