perf: trie conflict check in chisel-hacked - #41
Merged
Merged
Conversation
every patch in patches/chisel/ gets applied in name order, so adding one no longer means editing the script.
with CHISEL_HACKS=1, chisel-hacked used to skip release validation entirely. it now runs the full validate(), with the trie from canonical/chisel#302 in place of the quadratic path conflict loop. unset keeps upstream's loop. chisel info on the 24.04+ release branches goes from ~11-17s to ~80-170ms, against ~40-100ms when skipping. all current release branches validate cleanly.
letFunny/chisel#29 on top of the trie: reuse the traversal queues and look up literal child segments directly. ~10-25% off chisel info on the 24.04+ release branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHISEL_HACKS=1used to makechisel-hackedskip release validation entirely. now it runs the fullvalidate(), with the trie from canonical/chisel#302 in place of the quadratic path conflict loop, plus the letFunny/chisel#29 speedups on top. withCHISEL_HACKSunset it behaves like upstream.