Skip to content

perf: trie conflict check in chisel-hacked #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lczyk merged 3 commits into from
Sep 27, 2026
Merged

perf: trie conflict check in chisel-hacked #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bea8504
refactor: glob chisel patches in binary build
lczyk Sep 27, 2026
23f0549
perf: trie conflict check over skipped validation
lczyk Sep 27, 2026
3452c3e
perf: faster trie traversal
lczyk Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,9 @@ jobs:

**precompiled chisel-hacked binaries** -- chisel v1.5.0 with
CHISEL_HACKS patches applied. when `CHISEL_HACKS=1` is set,
skips release maintenance checks and release validation -- used
by chisel-releases tests against in-development releases.
skips release maintenance checks and validates releases with a
faster path conflict check -- used by chisel-releases tests
against in-development releases.
ships with `.sha256` and `.cosign.bundle` sidecars.

```
Expand Down
7 changes: 1 addition & 6 deletions hack/build_binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,7 @@ build chisel https://github.com/canonical/chisel "$CHISEL_REF" ./cmd/chisel \
# the hacked variant. Version string gets a -hacked suffix so `chisel-hacked
# --version` is distinguishable from the unpatched binary.
cd /src/chisel
patches=(
/patches/chisel/0001-*.patch
/patches/chisel/0002-*.patch
/patches/chisel/0003-*.patch
)
for p in "${patches[@]}"; do
for p in /patches/chisel/*.patch; do
echo "==> applying patch: $(basename "$p")"
git apply "$p"
done
Expand Down
27 changes: 0 additions & 27 deletions patches/chisel/0003-chore-skip-release-validation-via-CHISEL_HACKS.patch
View file
Open in desktop

This file was deleted.

Loading