Fix SYNC_MANAGER_CONTROL bitmasks for operation mode and direction#371
Open
trns1997 wants to merge 1 commit intoleducp:masterfrom
Open
Fix SYNC_MANAGER_CONTROL bitmasks for operation mode and direction#371trns1997 wants to merge 1 commit intoleducp:masterfrom
trns1997 wants to merge 1 commit intoleducp:masterfrom
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d753f78 |
leducp
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Section II Register Description:

SYNC_MANAGER_CONTROL_OPERATION_MODE_MASKwas0x01— bit 0 is always 0 for all valid modes (buffered=00, mailbox=10), so the check was a no-op.SYNC_MANAGER_CONTROL_DIRECTION_MASKwas0x02— bit 1 is the MSB of the operation mode field, not direction, soisSmValid()was accidentally checking mode (partially) while never checking direction at all.We've been always in an unconditionally true case, which is why everything works its just that we could have slaves that has its SMs configured incorrectly and
isSmValid()would have returned true.