Conversation
Contributor
|
Chat app preview deployed for
|
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qwen3.5's template rejects a typed tool result containing a Dart Map with
Unexpected content type, preventing the follow-up inference after a successful tool call. Normalize structured results to JSON text at the shared template-input boundary; preserve string results, source objects, and the public message JSON representation.Fixes #528.
Production-readiness scope
Completeness checklist
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 --exclude-tags local-only— 2,254 pass, three existing skips.dart test -p chrome --exclude-tags local-only— 960 pass.tool/testing/run_template_parity_suites.sh— template units, pinned upstream chat/parser suites, and compiled grammar acceptance/rejection pass.tool/docs/validate_links.sh— production docs build and links pass with Node 20.Matrix Evidence
2acefdc54fd29348ac89c84408a4ae8a639d22e2/ base6c01a69af5bd13b338763f5f63cf16e482aa9fd657d1997790d1744fba5b40a7317df71ea5e2acee28c47e78f0cce39c0703f8cf; temperature0, seed1, thinkingfalse, context1024, threads4, gpuLayers0. No timing/accelerator claim.Review Notes
2acefdc54fd29348ac89c84408a4ae8a639d22e2; live PR identity and zero review threads reverified. Code audit accepted. Expanded local strict typed-history tests independently reproduce pre-existing Qwen3.5 XML parser loses schema strings and exposes undeclared tool calls #530 failures (schema string123 becomes integer123; undeclared function produces a tool delta). Those unfinished test additions are not pushed; existing PR CI does not validate them. The readiness evaluator remains rejected and draft status is retained.High-risk regression review
codex-adversarial-tool-result-2acefdc5, separate audit agent; accepted exact committed diff.2acefdc54fd29348ac89c84408a4ae8a639d22e2/6c01a69af5bd13b338763f5f63cf16e482aa9fd6.rejected / unchangedEvidencePath. All six structured-output axes require changed tests (schema lines175–204; evaluator lines971–1030 and1087–1092). Existing compiled grammar, reconstruction, rollback, tool-choice/thinking, and upstream parity tests pass but are unchanged; new input-serialization tests do not replace those axes. The release-metadata exception does not apply. Draft retained; meaningful additional typed-history regressions were attempted, but their schema reconstruction and rollback assertions expose pre-existing Qwen3.5 XML parser loses schema strings and exposes undeclared tool calls #530. Those strict assertions remain failing and must be addressed through a separate parser fix before the expanded acceptance evidence can pass. No gate bypass or externally enforced readiness claim.