Fix schema-aware Qwen XML tool-call parsing - #531
Merged
Merged
Conversation
Contributor
|
Chat app preview removed for |
leehack
marked this pull request as ready for review
September 19, 2026 00:57
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qwen XML tool calls now honor supplied tool schemas: a declared string such as
"123"stays a string, and undeclared functions, duplicate/unknown parameters, missing required values, or invalid types produce no executable call. Invalid final output rolls back to raw content atomically.Fixes #530.
Production-readiness scope
Completeness checklist
Test Plan
codeas a string; result follow-ups return123, and recovery passes.Earlier full-run tooling timeouts are preserved in local evidence; the final entire run passed with unchanged timeouts. A first real-model follow-up produced quoted digits; an explicit digits-only prompt passed the unchanged strict output/type assertions.
Matrix Evidence
High-risk regression review
codex-adversarial-qwen-schema-0146fda1; exact-commit review accepted with 42 independently passing tests.0146fda15c4e4375cd72b79fe49f209e9a8d891c/6c01a69af5bd13b338763f5f63cf16e482aa9fd6.unverifiedPrerequisites/externalPrerequisitesUnavailable: local evidence cannot authenticate the dedicated GitHub App, independent auditor, protected environment or conditional ruleset. This is not operational merge readiness; remains draft.0146fda15c4e4375cd72b79fe49f209e9a8d891c, including Linux coverage, macOS, Windows, Chrome, Web Chat Contract, companions, docs and preview. No fixes or reruns required.