"Stream mode: Phase 4 finale" on top of lookup-file#130
Open
let-def wants to merge 10 commits into
Open
Conversation
Imported from a larger change by @merv1n34k as part of "Stream mode: Phase 3" (#125).
Owner
Author
|
@merv1n34k: If things looks good for you, I can merge #127 and #130, which should complete your 4 phases extension. |
Contributor
|
Hey @let-def! Thanks for the PR! I will take a look at it, but probably no sooner the end on April |
Owner
Author
|
Np, take your time. I hope it will mesh well with your plans. I will wait for your feedback before merging these PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of @merv1n34k #126 PR on top of #127.
It replaces the use of request-file by lookup-file, which now includes a "promised" status to notify the editor that the document is stuck on a promise made by the editor.