Repository navigation
Remove the tag kind, now implied by the tag's collection - #2758
Open
gabrielfruet wants to merge 2 commits into
Open
gabrielfruet wants to merge 2 commits into
gabrielfruet wants to merge 2 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 45 functions across 33 files. (11 skipped… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The description explains the removal of tag kind, the collection-based behavior, migration differences, GUI impact, testing results, known test limitations, and changelog status. It follows the requir… Title check The title clearly and concisely describes the primary change: removing tag kind because the collection now implies it.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 45 functions across 33 files. (11 skipped: 11 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
❌ Fast Track: checks did not pass
To run the guardrails locally, from Reflects |
gabrielfruet
added this pull request to stack #2781
October 13, 2026 19:27
A tag holds only samples of its own collection, so the sample type of the collection gives the kind. The downgrade restores kind from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The page still cleared the root collection's selection, left over from when annotation tags lived on the root collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gabrielfruet
force-pushed
the
gabriel-lig-10097-drop-tag-kind
branch
from
October 13, 2026 19:29
f453afb to
2484d70
Compare
This was referenced Oct 13, 2026
gabrielfruet
changed the title
Contributor
Author
|
/review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Stacked on #2757. A tag now holds only samples of its own collection, so
kindrepeats the collection's sample type. Creating a tag takes only{name}, and the PostHogsamples_taggedevent sendsgrid_typeinstead oftag_kind.The GUI looks the same: unlike #2737, which this replaces, image and annotation views keep separate tags. The annotations page now clears its own tag selection on entry, not the root collection's.
The Postgres downgrade restores
kindfrom each tag's collection, andsamplefor a tag whose collection was deleted. DuckDB has no migrations: an existing.dbkeeps aNOT NULL kindcolumn and cannot create tags until re-indexed.How has it been tested?
uv run pytest -n 8: 3246 passed. 3 failures and 4 collection errors needs3fs,adlfsor a built webapp.uv run pytest tests/database --postgres: 169 passed, including a downgrade case for a tag of a deleted collection.make static-checks: 0 errors.make test: 3336 passed. Not checked in a running GUI.Did you update CHANGELOG.md?
🤖 Generated with Claude Code