feat(help-dialog): add scroll direction arrow indicator - #57
Open
dungxnd wants to merge 2 commits into
Open
Conversation
Contributor
Author
Owner
|
The capped dialog height is a reasonable design choice to me. Without it, help sections with long descriptions would stretch the dialog to fill most of the screen, limit it to half the window height keeps the dialog compact and consistent. |
Contributor
Author
|
IKR, but I'm not talking about height, I'm talking about UX, when sometime description for long one is the same with the one that fit right at that capped height -> kinda confusing about the scrolling, so add an arrow indicator would be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why?
It look weird to have no scrollbar and every dialog just have the same height, so adding an arrow just to improve UX that they have more on the dialog.
Changes
In
EffectSection, the help dialog's text block now tracks scroll position and overlays a boundary-aware arrow hint:AnimatedVisibilitywithfadeIn/fadeOut.surfaceContainerHighbackground — the same color token M3AlertDialoguses for its container — so it blends naturally without any visible seam.Box.