Skip to content

feat(help-dialog): add scroll direction arrow indicator #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dungxnd wants to merge 2 commits into from
+47 −3
Closed

feat(help-dialog): add scroll direction arrow indicator #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a320dfa
feat(help-dialog): add scroll direction arrows
dungxnd Aug 15, 2026
2bd6c3d
refactor: DRY the arrow hint
dungxnd Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 47 additions & 3 deletions app/src/main/java/com/llsl/viper4android/ui/screens/main/EffectSections.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@ package com.llsl.viper4android.ui.screens.main

import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.expandVertically
import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut
import androidx.compose.animation.shrinkVertically
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.BoxScope
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
Expand All @@ -21,6 +25,8 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.TrendingUp
import androidx.compose.material.icons.filled.Add
import androidx.compose.material.icons.filled.KeyboardArrowDown
import androidx.compose.material.icons.filled.KeyboardArrowUp
import androidx.compose.material.icons.filled.AspectRatio
import androidx.compose.material.icons.filled.BlurCircular
import androidx.compose.material.icons.filled.BlurOn
Expand Down Expand Up @@ -66,6 +72,7 @@ import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.hapticfeedback.HapticFeedbackType
import androidx.compose.ui.platform.LocalDensity
Expand Down Expand Up @@ -95,6 +102,33 @@ private fun rawToDb(raw: Number): Double = 20.0 * log10(raw.toDouble() / 100.0)

private fun dbToRaw(db: Double): Int = (10.0.pow(db / 20.0) * 100.0).roundToInt()

@Composable
private fun BoxScope.ScrollArrowHint(
visible: Boolean,
alignment: Alignment,
icon: ImageVector,
color: Color,
) {
AnimatedVisibility(
visible = visible,
modifier = Modifier.align(alignment),
enter = fadeIn(),
exit = fadeOut(),
) {
Box(
modifier = Modifier.fillMaxWidth().height(28.dp).background(color),
contentAlignment = Alignment.Center,
) {
Icon(
imageVector = icon,
contentDescription = null,
tint = MaterialTheme.colorScheme.onSurfaceVariant,
modifier = Modifier.size(20.dp),
)
}
}
}

@OptIn(androidx.compose.foundation.ExperimentalFoundationApi::class)
@Composable
fun EffectSection(
Expand Down Expand Up @@ -204,9 +238,19 @@ fun EffectSection(
LocalWindowInfo.current.containerSize.height
.toDp() / 2
}
Column(
modifier = Modifier.heightIn(max = maxHeight).verticalScroll(rememberScrollState()),
) { RichText(text = stringResource(descriptionRes)) }
val scrollState = rememberScrollState()
// Show bottom ↓ only when resting at the very top and there is content below
val showBottomArrow = scrollState.value == 0 && scrollState.maxValue > 0
// Show top ↑ only when resting at the very bottom and there is content above
val showTopArrow = scrollState.maxValue > 0 && scrollState.value == scrollState.maxValue
val dialogColor = MaterialTheme.colorScheme.surfaceContainerHigh
Box(modifier = Modifier.heightIn(max = maxHeight)) {
Column(
modifier = Modifier.verticalScroll(scrollState),
) { RichText(text = stringResource(descriptionRes)) }
ScrollArrowHint(showTopArrow, Alignment.TopCenter, Icons.Default.KeyboardArrowUp, dialogColor)
ScrollArrowHint(showBottomArrow, Alignment.BottomCenter, Icons.Default.KeyboardArrowDown, dialogColor)
}
},
confirmButton = {
TextButton(onClick = { showHelpDialog = false }) {
Expand Down