Fix ABC aspect handling in keep-aspect mode#33
Open
zhgqfqxzdm wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ABC stretching to full 16:9 when manually set to 1920x1080 with KEEP_ASPECT_RATIO enabled.
Before this, ABC would boot looking stretched/wrong at first. Once it reached the high score screen / attract mode, it would correct itself and fit properly, which made it look like the render size changed partway through startup.
The issue was that ABC was using the manual window size as the blit size, so the aspect math treated it like it was already 16:9. This keeps ABC treated as 640x480 in the Windows keep-aspect path, so it stays 4:3 / 1440x1080 inside a 1920x1080 window.
KEEP_ASPECT_RATIO=false still fills the full window like before, and AUTO resolution behavior should be unchanged.
The Windows-only guard was added so this does not change Linux behavior without testing it there first.
AI Disclosure: AI assistance was used as a learning/reference aid and for error checking during this PR. The implementation, testing, debugging, and final review were performed manually.