ci: every pull request moves the engine version - #861
Merged
Conversation
The version names the vendored engine directory, is half of the BuildStamp a project compares itself against, and keys the pipeline cache. A number that sits still makes all three blind - #761 is what that looks like from the outside. It bumps the PR's own branch: the ruleset on development requires a pull request and has no bypass actors, so a workflow token cannot push there. Bumping from the BASE version rather than the branch's own keeps the step idempotent - pushing again recomputes the same number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine version is not decoration: it names
~/.local/share/kooch/<version>/engine, it is half of theBuildStampa project compares itself against, and it keys the pipeline cache. A version that does not move makes all three blind at once — that is #761, and until now the number moved by hand.How it works
pull_requestondevelopment→ bump[workspace.package]in the PR's own branch.feat!:/BREAKING CHANGE:→ major ·feat:→ minor · everything else → patch, because the rule is that the version moves with every change..github/scripts/bump_version.pydoes the edit and runscargo metadata --no-depsto prove the manifest still parses. Usable by hand:--bump patch,--set X.Y.Z,--print.Three decisions worth reviewing
development. The ruleset there requires a PR and has no bypass actors, so a workflow token cannot push to it at all. It also puts the version in the diff, where it is reviewable.no-version-bumpis the opt-out label.Known limit, stated rather than hidden: two PRs open at once both bump from the same base and collide on
Cargo.toml— a one-line conflict, resolved by merging one and pushing the other.Cargo.lockis gitignored in this repo. The script retags it for local runs, but CI has nothing to commit there. For a workspace that ships a binary editor that is worth revisiting — not in this PR.