You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revert "Publish full Moneybird records and Calendar schema metadata" - #70
I dug into what this actually reverts. PR #46 only added an #[ignore]d test in src/catalog.rs that loads a real, pinned localthought/overlays catalog revision and asserts facts about the composed Moneybird/Calendar output (collection count, throttling limits, recurrence schema field). It didn't add any runtime code, and it didn't hand-author any platform data in this repo — the actual Moneybird CRUD/throttling metadata and the Calendar recurrence schema fix all live correctly in localthought/overlays as OpenAPI Overlay documents, already published and already the production-pinned CATALOG_PATH default in src/config.rs.
That test follows the same pinned-fixture pattern already used by src/identity_catalog_tests.rs and the pre-existing ignored test in src/catalog.rs (see tests/identity-catalog/sources.json): loading real composed platform data to prove the generic load-and-compose pipeline produces the correct result for real inputs. That's a different, complementary check from localthought/overlays' own authoring-time validation, not a duplication of it, and it doesn't make any runtime code platform-specific.
I've added AGENTS.md to spell out the actual boundary (production src/ code must stay platform-agnostic; pinned-fixture tests asserting composed output are fine) so this doesn't need re-litigating next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #46
There should not be Moneybird-specific code in the integration-proxy