Skip to content

Revert "Publish full Moneybird records and Calendar schema metadata" - #70

Closed
michielbdejong wants to merge 1 commit into
mainfrom
revert-46-codex/publish-full-record-catalog
Closed

michielbdejong wants to merge 1 commit into
mainfrom
revert-46-codex/publish-full-record-catalog

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Reverts #46

There should not be Moneybird-specific code in the integration-proxy

@michielbdejong

Copy link
Copy Markdown
Contributor Author

False alarm — closing without merging.

I dug into what this actually reverts. PR #46 only added an #[ignore]d test in src/catalog.rs that loads a real, pinned localthought/overlays catalog revision and asserts facts about the composed Moneybird/Calendar output (collection count, throttling limits, recurrence schema field). It didn't add any runtime code, and it didn't hand-author any platform data in this repo — the actual Moneybird CRUD/throttling metadata and the Calendar recurrence schema fix all live correctly in localthought/overlays as OpenAPI Overlay documents, already published and already the production-pinned CATALOG_PATH default in src/config.rs.

That test follows the same pinned-fixture pattern already used by src/identity_catalog_tests.rs and the pre-existing ignored test in src/catalog.rs (see tests/identity-catalog/sources.json): loading real composed platform data to prove the generic load-and-compose pipeline produces the correct result for real inputs. That's a different, complementary check from localthought/overlays' own authoring-time validation, not a duplication of it, and it doesn't make any runtime code platform-specific.

I've added AGENTS.md to spell out the actual boundary (production src/ code must stay platform-agnostic; pinned-fixture tests asserting composed output are fine) so this doesn't need re-litigating next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant