This repository was archived by the owner on Sep 23, 2026. It is now read-only.
Repository navigation
Build on prepare so publishes ship fresh output (0.17.1) - #9
Merged
Merged
Conversation
…7.1) The package ships a prebuilt build/src (gitignored) but had no prepublishOnly/ prepare hook, so `npm publish` shipped whatever build/ happened to be in the working tree — which is how 0.17.0 went out with a stale build missing the #7 fixes. Add `prepare: npm run build:release` so the output is always rebuilt from source before packing (and when the package is installed as a git dependency), and bump to 0.17.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BdadF8jAvK2e8Fmis3hLJF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build/is git-ignored andfilespublishesbuild/src, but there was noprepublishOnly/preparehook — sonpm publishships whateverbuild/is in the working tree. That's how 0.17.0 went out with a stale build missing the #7 fixes (identityField, PATCH updates, array pagination): the published tarball'sbuild/srcpredated those changes.Fix
Add
prepare: npm run build:releaseso the output is always rebuilt from source before packing (and when the package is installed as a git dependency, which is howlocalthought/reflectorconsumes it in the meantime). Bump to 0.17.1.Verified:
npm packnow produces a tarball whosebuild/src/client/client.{js,d.ts}containsidentityFieldand whosediscover.jscontainsupdateMethod.Note on the npm registry
npm's published
0.17.0is still the stale build. Republishing as0.17.1(this version, now thatprepareguarantees a correct build) will fix the registry. Reflector currently pins the git commit, so it isn't blocked on that.🤖 Generated with Claude Code
https://claude.ai/code/session_01BdadF8jAvK2e8Fmis3hLJF
Generated by Claude Code