fix(smokes): cover new goal configuration catalog features - #3942
huangruiteng merged 1 commit into
Conversation
huangruiteng
left a comment
There was a problem hiding this comment.
结论:REQUEST CHANGES。
- 变更范围与价值
这个 PR 只扩展 examples/project/configure-goal-smoke.py,把已经进入统一 goal configuration catalog 的 local_authority_shadow 和 periodic_report 纳入 durable smoke。这里不是单纯重复 capability 自身测试:它守住的是统一 configure-goal 发现面上的 feature 集合、default-off 语义、current 值以及 preview/apply/verify 命令形态,因此有实际的回归价值。
- 设计检查
新增断言与两个能力的公开契约一致:local_authority_shadow 保持 experimental_opt_in、默认关闭,preview 不带 --execute 而 apply 带;periodic_report 保持 supported_explicit_override、默认关闭,并且未设置 goal override 时不伪造 goal-scoped current。没有看到扩大普通用户默认行为或隐式启用能力的问题。
- 独立验证
我在 exact head 81ebb03daf17d13c1ccf59df74144b6760cb1c9b 上运行了 configure-goal smoke,结果为 configure-goal-smoke ok;py_compile 与 git diff --check 也通过。DCO、dependency review、Windows 和 Sonar 检查均为通过。
- 阻塞项
当前 required pytest 仍然失败。唯一失败是 tests/capabilities/test_pr_review_contract.py::test_execution_contract_owns_deep_review_requirements:基线文本仍为 Flag silent changes ...,而测试要求包含精确语义 silent behavior changes。这与本 PR 的 smoke diff 无关,修复已位于尚未合入的 #3940,但在本 exact head 上 required CI 仍为红色,因此现在不能批准。
- 建议下一步
请等待 #3940 合入后 rebase 到最新 main,重新触发 required pytest;如果 exact head 的 required checks 全绿且本变更保持不变,即可重新评审。
English verdict: REQUEST CHANGES — the smoke additions are well-scoped and independently pass, but the exact head still has a failing required pytest check; rebase after #3940 lands and rerun CI.
`examples/project/configure-goal-smoke.py` pinned the goal configuration catalog to eight feature ids, so the Full Public Smokes baseline went red once the catalog started reporting `local_authority_shadow` (Stage 2C local post-commit authority observation, loopx-project#3882) and `periodic_report` (Goal-scoped periodic-report override, loopx-project#3865/loopx-project#3910). Extend the expected feature set and assert both features' default-off semantics for a Goal that never opted in: - `local_authority_shadow` is `experimental_opt_in`, reports the closed `{"enabled": False, "mode": None, "status": "disabled"}` summary, and its preview/apply commands follow the preview-without-execute contract. - `periodic_report` is `supported_explicit_override` with default `{"enabled": False, "timezone": "UTC"}`; a Goal without an override follows the machine default, so the catalog deliberately reports no Goal-scoped `current` value rather than a synthetic one. No product behavior or default changes; smoke-only. Validation: python3 examples/project/configure-goal-smoke.py Signed-off-by: song <liusongstep@gmail.com> (cherry picked from commit ec9bf3c9c8704c84bf59157f2e2a0b5a8b78a99b)
81ebb03 to
dcab939
Compare
|
Rebased onto official |
Summary
examples/project/configure-goal-smoke.pyasserted an exact default-off feature set that no longer matches the goal configuration catalog:local_authority_shadow(Stage 2C, feat(control-plane): add Stage 2C local authority cutover kernel #3882) andperiodic_report(feat(machine-config): add generic operator configuration surfaces #3865 / feat: unify machine and Goal capability configuration #3910) are now reported, so the smoke fails on shard 3 ofFull Public Smokeson everymainhead since343b5f972.local_authority_shadowisexperimental_opt_inwithcurrent == {"enabled": false, "mode": null, "status": "disabled"}and a preview/apply--executecontract;periodic_reportissupported_explicit_override, default{"enabled": false, "timezone": "UTC"}, and intentionally carries nocurrentkey while the Goal has no override (the configuration UI already treats it as optional).Companion baseline PRs for the other shard failures: #3943 (concise help and manpage parity) and #3944 (
todo.pyowner extraction). Each is independent and can merge in any order.Issue Or Task
Full Public Smokesworkflow onmainValidation
python3 -m py_compile examples/project/configure-goal-smoke.pypython3 examples/project/configure-goal-smoke.py->configure-goal-smoke okpython3 examples/run-smokes.py --script examples/project/configure-goal-smoke.py-> okloopx canary premerge --from-git-diff --git-diff-base <official main>-> 13/13 selected checks passed, 0 manual holdsgit diff --checkclean; commit carries the DCO trailerType of Change
LoopX Area
Technical Direction
Core control-plane hardening
Target base branch:
mainDirection tracker or promotion unit:
Full Public SmokesbaselineBoundary Checklist
.loopx/,.codex/goals/, liveACTIVE_GOAL_STATE.md, credentials, private benchmark traces, verifier output, raw agent sessions, internal document links, or local machine paths.Signed-off-bytrailer (git commit -s).