Conversation
`examples/cli-help-manpage-smoke.py` went red on the Full Public Smokes baseline for three help-surface drifts that all trace back to recently merged commands: - loopx-project#3882 added a two-line `loopx coordination-shadow --help` entry to the bare `loopx` / `loopx --help` first screen, pushing the concise help to 41 lines against the smoke's 39-line concise-default budget. The command is a default-off, experimental Stage 2C admin surface, so it does not belong on the first screen. Drop it from `render_concise_help`; it stays listed under "Daily operator commands" in `loopx commands` and in the manual, so the agent-facing output-budget classification is unchanged. - loopx-project#3865 registered the top-level `machine-config` command without classifying it for the manual. Add it to `MANPAGE_COMMAND_HELP_ONLY`, matching its Goal-scoped sibling `configure-goal`. - The checked-in `man/loopx.1` was never regenerated after loopx-project#3882 added `coordination-shadow` to the command catalog. Regenerate it with `scripts/render-manpage.py --output man/loopx.1`. Default-behavior disclosure: the bare `loopx` / `loopx --help` first screen no longer lists `loopx coordination-shadow --help` (back to 39 lines). The grouped reference (`loopx commands`) and the manual page are unchanged in membership; the manual gains the catalog row it was already missing. The 39-line budget was not raised. Validation: - PATH with system bash first: python3 examples/cli-help-manpage-smoke.py -> cli-help-manpage-smoke ok - python3 examples/cli-control-plane-command-modularization-smoke.py -> ok - python3 examples/cli-bootstrap-rollout-helper-command-modularization-smoke.py -> ok - python3 -m pytest tests/control_plane/test_cli_output_budget.py -q -> 21 passed Signed-off-by: song <liusongstep@gmail.com> (cherry picked from commit 053bd1c795f889724d93dd22c4b97cb793eba906)
This was referenced Sep 4, 2026
Collaborator
Author
|
Closing to keep the review queue small. The 39-line first-screen breach can only be resolved by an owner decision (drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/cli-help-manpage-smoke.pyfails onmainbecause the concise default help grew to 41 lines against its 39-line budget after feat(control-plane): add Stage 2C local authority cutover kernel #3882 put a two-linecoordination-shadow --helpentry on the first screen; the checked-inman/loopx.1was also never regenerated after that change, andmachine-config(feat(machine-config): add generic operator configuration surfaces #3865) was left unclassified for the manual.coordination-shadowfromrender_concise_helponly. It remains inloopx commands, in its own--help, and in the manual. Classifymachine-configas manpage/help-only like its siblingconfigure-goal, and regenerateman/loopx.1from the canonical catalog.loopxandloopx --helpno longer listcoordination-shadow. The 39-line first-screen budget is kept rather than raised, because the Stage 2C file shadow is a default-off experimental admin surface. If maintainers prefer the entry on the first screen, the alternative is to raise the budget in the smoke; that is an explicit owner decision and this PR does not pre-empt it.turn.pyandtodo.pyare untouched.Companion baseline PRs for the other shard failures: #3942 (goal configuration catalog smoke) and #3944 (
todo.pyowner extraction). Each is independent and can merge in any order.Issue Or Task
Full Public Smokesworkflow onmain(shard 0)Validation
python3 -m py_compile loopx/help_surface.pypython3 examples/cli-help-manpage-smoke.py->cli-help-manpage-smoke okpython3 scripts/render-manpage.py --check man/loopx.1-> parityloopxhelp -> 39 linespython3 -m pytest tests/control_plane/test_cli_output_budget.py -q-> 21 passed (agent-facing manifest unchanged)cli-control-plane-command-modularizationandcli-bootstrap-rollout-helpersmokes -> okloopx canary premerge --from-git-diff --git-diff-base <official main>-> 2/2 selected checks passed, 0 manual holdsgit diff --checkclean; commit carries the DCO trailerType of Change
LoopX Area
Technical Direction
Core control-plane hardening
Target base branch:
mainDirection tracker or promotion unit:
Full Public SmokesbaselineBoundary Checklist
.loopx/,.codex/goals/, liveACTIVE_GOAL_STATE.md, credentials, private benchmark traces, verifier output, raw agent sessions, internal document links, or local machine paths.Signed-off-bytrailer (git commit -s).