fix(todo): preserve zero monitor generation metadata - #4199
Merged
huangruiteng merged 1 commit intoSep 11, 2026
Merged
huangruiteng merged 1 commit into
huangruiteng merged 1 commit into
Conversation
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
10 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0formaterial_change_generationwhen rendering Todo Markdown metadataWhy
PR #4187 adds production-scale Monitor fixtures whose generations include
0. The Markdown formatter previously dropped those zero values, so rebuilding the Todo projection produced 22 records with an absent generation and failed the parse/render parity check.This patch fixes that latent contract bug. PR #4187 should also update to the latest
main, which already includes #4186 and resolves its separate Lark maintainability-ratchet failure.Validation
tests/control_plane/test_todo_metadata_schema.pyandtests/control_plane/test_todo_projection_recovery.py: 30 passedtests/control_plane/test_todo_external_wait.py: 8 passedloopx checkon the changed source and test: 0 errors, 0 warningsmain+ this commit: both previously failing Python tests passedtodo-deferred-capacity-cli-smoke.pyfailure is an unchanged current-mainerror-message wording mismatch outside this patchSigned-off-by: BigDataDZ 76271875+BigDataDZ@users.noreply.github.com