Skip to content

fix(todo): preserve zero monitor generation metadata #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 11, 2026
Merged

fix(todo): preserve zero monitor generation metadata #4199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion loopx/control_plane/todos/contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,9 @@ def _metadata_value_is_present(value: Any) -> bool:
_TodoMetadataField(
key,
_nonempty_metadata_text,
write_normalizer=_truthy_value,
write_normalizer=normalize_todo_generation
if key == "material_change_generation"
else _truthy_value,
)
for key in TODO_MONITOR_METADATA_FIELDS
),
Expand Down
2 changes: 2 additions & 0 deletions tests/control_plane/test_todo_metadata_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def test_todo_metadata_round_trip_preserves_canonical_values() -> None:
result_hash="abc123",
consecutive_no_change="2",
material_change="false",
material_change_generation=0,
max_no_change_before_replan="3",
note="focused validation passed",
evidence="receipt cqr_123",
Expand Down Expand Up @@ -124,6 +125,7 @@ def test_todo_metadata_round_trip_preserves_canonical_values() -> None:
"result_hash": "abc123",
"consecutive_no_change": "2",
"material_change": "false",
"material_change_generation": "0",
"max_no_change_before_replan": "3",
"note": "focused validation passed",
"evidence": "receipt cqr_123",
Expand Down