Fix flaky RestoreFromBackupAsync test: replace Progress<T> with synchronous IProgress<T> - #3
Merged
Merged
Conversation
Co-authored-by: lukislp <155678024+lukislp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'test-unit'
Fix flaky Aug 6, 2026
RestoreFromBackupAsync test: replace Progress<T> with synchronous IProgress<T>
lukislp
marked this pull request as ready for review
August 6, 2026 13:31
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RestoreFromBackupAsync_ValidUnencryptedBackup_RunsImportButFailsAtRelationalOnlyTallySteptest was failing non-deterministically in CI. The root cause: it usednew Progress<RestoreProgress>(...), which dispatches its callback asynchronously on the ThreadPool (noSynchronizationContextin xUnit). The first progress event (RestoreStep.Validating) is reported before anyawait, so its callback races the test's assertion and can miss the list.Changes
DatabaseRestoreServiceTests.cs— replace theProgress<T>instance withSyncProgress<T>, a minimalfile-scopedIProgress<T>that invokes the handler synchronously on the calling thread, making event capture deterministic:No production code was changed.