Skip to content

Fix flaky RestoreFromBackupAsync test: replace Progress<T> with synchronous IProgress<T> #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukislp merged 2 commits into from
Aug 6, 2026
Merged

Fix flaky RestoreFromBackupAsync test: replace Progress<T> with synchronous IProgress<T> #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6a496e
Initial plan
Copilot Aug 6, 2026
c47e839
Apply remaining changes
Copilot Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions LagersystemLVHome.UnitTests/Services/Backup/DatabaseRestoreServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public async Task RestoreFromBackupAsync_ValidUnencryptedBackup_RunsImportButFai
var backupService = Substitute.For<IBackupManagementService>();
var sut = CreateSut(targetFactory, NewTempDir(), backupService: backupService);
var progressEvents = new List<RestoreProgress>();
var progress = new Progress<RestoreProgress>(p => progressEvents.Add(p));
IProgress<RestoreProgress> progress = new SyncProgress<RestoreProgress>(p => progressEvents.Add(p));

var result = await sut.RestoreFromBackupAsync(new MemoryStream(zipBytes), progress: progress);

Expand Down Expand Up @@ -528,6 +528,11 @@ public async Task CreateSafetyBackupAsync_CreatesSafetyDirectoryAndDelegatesToBa

path.Should().StartWith(Path.Combine(webRoot, "backups", "safety"));
Directory.Exists(Path.Combine(webRoot, "backups", "safety")).Should().BeTrue();
await backupService.Received(1).CreateBackupAsync(Arg.Any<CancellationToken>());
}
}

/// <summary>Invokes the progress handler synchronously on the calling thread, avoiding the async dispatch of <see cref="Progress{T}"/>.</summary>
file sealed class SyncProgress<T>(Action<T> handler) : IProgress<T>
{
public void Report(T value) => handler(value);
}
Loading