Patch/sync upstream 2026 01 15 #55

manthanabc · 2026-01-16T10:57:52Z

No description provided.

…(#2127) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

…for shell commands (#2145) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

…ity (#2146)

…istic cwd (#2150)

Co-authored-by: Amit Singh <amitksingh1490@gmail.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

…ng (#2152) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

… errors (#2167)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

…and module consolidation (#2203)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

…(#2222) Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Co-authored-by: ForgeCode <noreply@forgecode.dev>

Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

…#2246)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

Co-authored-by: ForgeCode <noreply@forgecode.dev>

manthanabc · 2026-01-20T20:29:45Z

Todo: migrate histfile commits, and cleanup on changes.

manthanabc · 2026-01-23T09:09:06Z

crates/paws_app/src/fmt/fmt_output.rs

        match self {
-            ToolOperation::FsRead { input: _, output: _ } => None,
-            ToolOperation::ImageRead { output: _ } => None,
-            ToolOperation::FsCreate { input, output } => {


We do want previews for fs create

manthanabc · 2026-01-23T09:10:51Z

crates/paws_app/src/tool_executor.rs

            }
+            ToolCatalog::SemSearch(_) => {
+                // Semantic search is not implemented in Paws yet
+                anyhow::bail!("Semantic search is not yet supported")


Just drop the tool entirely

manthanabc · 2026-01-23T09:12:12Z

crates/paws_app/src/tool_resolver.rs

+        ("search", ToolName::new("fs_search")),
+        ("Read", ToolName::new("read")),
+        ("Write", ToolName::new("write")),
+    ])


Do a clean replace, no part should refer to dpericated names

manthanabc · 2026-01-23T09:14:38Z

crates/paws_domain/src/compact/summary.rs

            .map(|pattern| SummaryTool::Search { pattern }),
+        ToolCatalog::SemSearch(input) => Some(SummaryTool::Search {
+            pattern: input
+                .queries


manthanabc · 2026-01-23T09:23:35Z

Keep print conversation

manthanabc · 2026-01-23T09:56:13Z

Bug: Spinner stuck on loading after dump conversation

- Added `SetMinimaxParams` transformer to handle specific Minimax model parameters (temperature, top_p, top_k). - Integrated Minimax transformer into the OpenAI provider pipeline. - Added `input_modalities` field to `paws_domain::Model` to track supported input types (Text, Image). - Updated Anthropic, Gemini, and OpenAI model DTOs to populate `input_modalities`. - Cleaned up unused snapshots and benchmark files.

Copilot

Pull request overview

This PR syncs 114 upstream commits from the Forge repository to the Paws fork (as of 2026-01-15), applying bug fixes, new features, and improvements while maintaining fork-specific customizations. The changes are split into batches to manage risk.

Changes:

Removes semantic search tool (sem_search) and templates
Adds image/PDF reading support to fs_read tool with MIME detection
Adds validation framework with SyntaxError type for file operations
Introduces permission checking system and restricted mode support
Updates tool descriptions to use external markdown files with template rendering
Adds HTTP 522 to retry status codes and helper functions

Reviewed changes

Copilot reviewed 180 out of 181 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
docs/migrations/*.md	Documents the sync process, batches, and migration history
templates/paws-partial-summary-frame.md	Removes sem_search template block
crates/paws_domain/src/validation.rs	Adds SyntaxError type for validation
crates/paws_services/src/tool_services/fs_read.rs	Adds image/PDF support, line truncation, MIME detection
crates/paws_services/src/policy.rs	Removes message field from Execute operation
crates/paws_domain/src/tools/descriptions/*.md	New external tool description files
crates/paws_app/src/template_engine.rs	Adds 'contains' handlebars helper
crates/paws_app/src/tool_resolver.rs	Adds tool aliases for backward compatibility
crates/paws_domain/src/model.rs	Adds input_modalities field to Model
crates/paws_common/src/json_repair/*.rs	Adds schema coercion and fixes regex parser
.github/workflows/release.yml	Removes homebrew release job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-26T20:47:51Z

crates/paws_services/src/tool_services/fs_read.rs

+                    "PDF exceeds size limit. Use a smaller PDF or increase FORGE_MAX_IMAGE_SIZE."
+                } else {
+                    "Image exceeds size limit. Compress the image or increase FORGE_MAX_IMAGE_SIZE."
+                }


The error message contains "FORGE_MAX_IMAGE_SIZE" which should be changed to "PAWS_MAX_IMAGE_SIZE" to match the Paws fork naming convention.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-26T20:47:51Z

...aws_domain/src/tools/snapshots/paws_domain__tools__catalog__tests__tool_definition_json.snap

    "cwd": {
-      "description": "The working directory where the command should be executed.",
-      "type": "string"
+      "description": "The working directory where the command should be executed. If not specified, defaults to the current working directory from the environment.",
+      "type": "string",
+      "nullable": true


The Shell tool's cwd parameter is now optional (nullable) but the description says "If not specified, defaults to the current working directory from the environment." This is correct, but ensure all call sites handle the Option correctly and default to the environment cwd when None.

@copilot open a new pull request to apply changes based on this feedback, please do check skip opening the PR if is found consistent

Copilot · 2026-01-26T20:47:52Z

crates/paws_repo/src/agents/sage.md

  - fetch
-  - read_image
  - search


The read_image tool has been removed from the agents (sage.md line 10, muse.md line 13) but is still present in paws.md line 18 and the implementation still exists in the codebase. This is inconsistent. Either remove read_image from all agents including paws.md, or add it back to sage and muse if image reading is still supported.

@copilot open a new pull request to apply changes based on this feedback, keeping read_image

Copilot · 2026-01-26T20:47:52Z

echo

+a
+b
+c
+d


The file named "echo" appears to be accidentally committed. It contains only test data (a, b, c, d) and doesn't have a meaningful extension or purpose in the repository structure.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-26T21:11:43Z

@manthanabc I've opened a new pull request, #74, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-26T21:12:16Z

@manthanabc I've opened a new pull request, #75, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-26T21:12:58Z

@manthanabc I've opened a new pull request, #76, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-26T21:13:16Z

@manthanabc I've opened a new pull request, #77, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * fix: update error messages to use PAWS_MAX_IMAGE_SIZE instead of FORGE_MAX_IMAGE_SIZE Co-Authored-By: ForgeCode <noreply@forgecode.dev> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com>

* Initial plan * feat: restore read_image tool to sage and muse agents Co-Authored-By: ForgeCode <noreply@forgecode.dev> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com>

* Initial plan * Remove accidentally committed echo file Co-Authored-By: ForgeCode <noreply@forgecode.dev> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com>

laststylebender14 and others added 21 commits January 15, 2026 17:20

feat(permissions): add configurable tool permission checking via env …

b800c02

…(#2127) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

fix(permissions): ask the confirmation message for adding permission …

67141b0

…for shell commands (#2145) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

chore(tool_output): group none-returning tool operations for readabil…

a6b6725

…ity (#2146)

test(operation): fix flaky test_fs_remove_success by setting determin…

cda62e3

…istic cwd (#2150)

refactor(agent): make compact field required with default value (#2149)

c197d98

Co-authored-by: Amit Singh <amitksingh1490@gmail.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(shell): clarify cwd usage to prevent redundant cd commands (#2156)

820e15e

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(operation): use cdata for warning messages to prevent html escapi…

6a34759

…ng (#2152) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

fix(fs): cap end_line at total_lines in file info (#2170)

c4cb295

fix(workspace): reduce default batch size to 1 to prevent token limit…

beeb0e5

… errors (#2167)

fix(select): adjust cursor position in prompt suffix (#2139)

d4b35fd

fix(auth): prefill existing api key in prompt (#2138)

64a7bf9

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

fix(ui): simplify provider switch display message (#2151)

0a997e6

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

refactor: eliminate dead code warnings through targeted code cleanup …

ca7f764

…and module consolidation (#2203)

fix(json-repair): prevent index out of bounds in regex parser (#2214)

6924dc9

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

feat(json-repair): add schema-based type coercion for tool arguments …

9a8263b

…(#2222) Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

chore: add HTTP 522 to retry status codes (#2238)

639edb3

Co-authored-by: ForgeCode <noreply@forgecode.dev>

feat: add 'contains' helper for Handlebars templates (#2239)

09f991b

Co-authored-by: ForgeCode <noreply@forgecode.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(tools): add case insensity check for tool_calls to avoid errors (…

003295e

…#2246)

fix(tools): use empty object as default for ToolCallArguments (#2251)

14d49c0

fix(ui): restore cursor visibility on ctrl+c (#2209)

2f6015d

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

feat(html): add error styling for failed tool calls (#2223)

66d2c9c

Co-authored-by: ForgeCode <noreply@forgecode.dev>

github-actions bot added the type: fix Iterations on existing features or infrastructure. label Jan 16, 2026

manthanabc added 3 commits January 16, 2026 21:15

fix: resolve compilation errors and warnings

75e082b

drop homebrew and fix builds

9950258

feat: cleanup, keep new spinner and writer

041518f

manthanabc commented Jan 23, 2026

View reviewed changes

manthanabc requested a review from Copilot January 26, 2026 20:44

Copilot started reviewing on behalf of manthanabc January 26, 2026 20:44 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 26, 2026

Remove accidentally committed echo file #74

Merged

Copilot AI mentioned this pull request Jan 26, 2026

Restore read_image tool to sage and muse agents #75

Merged

Copilot AI mentioned this pull request Jan 26, 2026

fix(shell): explicitly default to environment cwd when None #76

Closed

Copilot AI mentioned this pull request Jan 26, 2026

Fix error messages to use PAWS_MAX_IMAGE_SIZE naming convention #77

Merged

Copilot AI and others added 3 commits January 26, 2026 21:29

Patch/sync upstream 2026 01 15 #55

Are you sure you want to change the base?

Patch/sync upstream 2026 01 15 #55

Uh oh!

Conversation

manthanabc commented Jan 16, 2026

Uh oh!

manthanabc commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manthanabc commented Jan 23, 2026

Uh oh!

manthanabc commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants