Skip to content

Restore read_image tool to sage and muse agents#75

Merged
manthanabc merged 2 commits intopatch/sync-upstream-2026-01-15from
copilot/sub-pr-55-again
Jan 26, 2026
Merged

Restore read_image tool to sage and muse agents#75
manthanabc merged 2 commits intopatch/sync-upstream-2026-01-15from
copilot/sub-pr-55-again

Conversation

Copy link

Copilot AI commented Jan 26, 2026

The read_image tool was removed from sage.md and muse.md but retained in paws.md, creating inconsistent tool availability across agents.

Changes

  • Restored read_image to sage.md tools list
  • Restored read_image to muse.md tools list

All three agents (sage, muse, paws) now have consistent image reading capabilities.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-Authored-By: ForgeCode <noreply@forgecode.dev>

Co-authored-by: manthanabc <48511543+manthanabc@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on sync upstream PR while retaining read_image functionality Restore read_image tool to sage and muse agents Jan 26, 2026
Copilot AI requested a review from manthanabc January 26, 2026 21:17
@manthanabc manthanabc marked this pull request as ready for review January 26, 2026 21:30
Copilot AI review requested due to automatic review settings January 26, 2026 21:30
@manthanabc manthanabc merged commit 4dd3aa6 into patch/sync-upstream-2026-01-15 Jan 26, 2026
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to restore the read_image tool to the sage and muse agents to achieve consistent tool availability across all three agents (sage, muse, and paws). However, the implementation is incomplete and will cause runtime failures.

Changes:

  • Added read_image to sage.md tools list
  • Added read_image to muse.md tools list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/paws_repo/src/agents/sage.md Adds read_image tool to sage agent's available tools
crates/paws_repo/src/agents/muse.md Adds read_image tool to muse agent's available tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- search
- plan
- sage
- read_image
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The read_image tool cannot be used because it is not registered in the ToolCatalog enum. While the ReadImage struct exists in crates/paws_domain/src/tools/catalog.rs (line 95), it is not included as a variant in the ToolCatalog enum (lines 40-54).

The tool registry checks ToolCatalog::contains() before executing tools (see crates/paws_app/src/tool_registry.rs line 101), which means any agent attempting to call read_image will receive a "Tool not found" error at runtime.

To fix this issue, you need to:

  1. Add ReadImage(ReadImage) as a variant to the ToolCatalog enum in crates/paws_domain/src/tools/catalog.rs
  2. Add the corresponding match arm in the ToolExecutor::call_internal method in crates/paws_app/src/tool_executor.rs to handle the execution
  3. Add match arms for ReadImage in all other places where ToolCatalog variants are matched (like description(), schema(), etc.)

Note: This same issue exists in paws.md which also lists read_image on line 18.

Suggested change
- read_image

Copilot uses AI. Check for mistakes.
tools:
- read
- fetch
- read_image
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The read_image tool cannot be used because it is not registered in the ToolCatalog enum. While the ReadImage struct exists in crates/paws_domain/src/tools/catalog.rs (line 95), it is not included as a variant in the ToolCatalog enum (lines 40-54).

The tool registry checks ToolCatalog::contains() before executing tools (see crates/paws_app/src/tool_registry.rs line 101), which means any agent attempting to call read_image will receive a "Tool not found" error at runtime.

To fix this issue, you need to:

  1. Add ReadImage(ReadImage) as a variant to the ToolCatalog enum in crates/paws_domain/src/tools/catalog.rs
  2. Add the corresponding match arm in the ToolExecutor::call_internal method in crates/paws_app/src/tool_executor.rs to handle the execution
  3. Add match arms for ReadImage in all other places where ToolCatalog variants are matched (like description(), schema(), etc.)

Note: This same issue exists in paws.md which also lists read_image on line 18.

Suggested change
- read_image

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants