RBS: Update signatures of lex_file and parse_file - #1990
Open
domingo2000 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
ruby
Contributor
Author
|
@marcoroth feel free to edit the PR in any way you need. Just left here the fix that will fix our RBI tapioca generation that I tested in my local branch. Here is an image before and after applying the fix locally: 
|
With his we prevent having issues with tapioca rbi generation because of the invalid RBS for this method omitting the ** argument
domingo2000
force-pushed
the
fix/fix-rbs-signature-for-lext-file-and-parse-file
branch
from
August 4, 2026 05:19
1ed8fdb to
1ccce8a
Compare
marcoroth
changed the title
lex_file and parse_file
marcoroth
changed the title
lex_file and parse_filelex_file and parse_file
marcoroth
reviewed
Aug 4, 2026
| module Herb | ||
| class << self | ||
| #: (String path, ?arena_stats: bool) -> LexResult | ||
| #: (String path, ?arena_stats: bool, **untyped) -> LexResult |
Owner
There was a problem hiding this comment.
As mentioned in #1989 (comment), we probably want to remove the **untyped and enumerate all kwargs again in the actual method declaration:
#: (String path, ?arena_stats: bool) -> LexResult
def lex_file(path, arena_stats: nil)
lex(File.read(path), arena_stats:)
endI wish there was a way around this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1989
With his we prevent having issues with tapioca
rbi generation because of the invalid
RBS for this method omitting the ** argument