Skip to content

RBS: Update signatures of lex_file and parse_file #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domingo2000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RBS: Update signatures of lex_file and parse_file #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/herb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ module Herb

module Herb
class << self
#: (String path, ?arena_stats: bool) -> LexResult
#: (String path, ?arena_stats: bool, **untyped) -> LexResult

@marcoroth marcoroth Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #1989 (comment), we probably want to remove the **untyped and enumerate all kwargs again in the actual method declaration:

#: (String path, ?arena_stats: bool) -> LexResult
def lex_file(path, arena_stats: nil)
  lex(File.read(path), arena_stats:)
end

I wish there was a way around this.

def lex_file(path, **)
lex(File.read(path), **)
end

#: (String path, ?track_whitespace: bool, ?analyze: bool, ?strict: bool, ?action_view_helpers: bool, ?transform_conditionals: bool, ?strict_locals: bool, ?prism_nodes: bool, ?prism_nodes_deep: bool, ?prism_program: bool, ?arena_stats: bool) -> ParseResult
#: (String path, ?track_whitespace: bool, ?analyze: bool, ?strict: bool, ?action_view_helpers: bool, ?transform_conditionals: bool, ?strict_locals: bool, ?prism_nodes: bool, ?prism_nodes_deep: bool, ?prism_program: bool, ?arena_stats: bool, **untyped) -> ParseResult
def parse_file(path, **)
parse(File.read(path), **)
end
Expand Down
8 changes: 4 additions & 4 deletions sig/herb.rbs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading