Skip to content

cloud: re-sync the proto copy with the cloud's source of truth - #91

Merged
marvinvr merged 5 commits into
mainfrom
issue-38
Sep 30, 2026
Merged

marvinvr merged 5 commits into
mainfrom
issue-38

Conversation

@marvinvr

@marvinvr marvinvr commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Brings cloud/proto back to byte-identical with the DockTail Cloud control plane's copy of the wire contract, which had drifted:

  • DefaultTailnetProbeIntervalMS takes the control plane's value (120_000). The agent never reads it — it is the cloud's own polling cadence; the agent-enforced floor (MinTailnetProbeIntervalMS) is unchanged.

  • ValidateHTTPPath is exported, as it is in the upstream copy. No agent code referenced the unexported name.

  • doc.go and the Service.Key / LogModeIncident / LogModeOff / public-vantage comments are reconciled so the same file reads true in both repositories (e.g. LogModeOff is also the fail-closed value SafeLogMode returns for an empty, invalid or reserved mode).

  • AGENTS.md notes that cloud/proto is a verbatim copy that must only change in lockstep with the control plane's.

  • Also carries the new http_status check class (identical to the lines in fix(cloud): let slow HTTP checks degrade and classify status mismatches correctly #90, so the two PRs merge cleanly in either order).

No existing wire shapes, field names or agent behaviour change.

Refs marvinvr/docktail-cloud#38

Summary by CodeRabbit

  • New Features
    • HTTP checks can now distinguish unexpected non-5xx status codes with a dedicated result classification.
  • Improvements
    • Tailnet service probes now run every two minutes instead of every five, so eligible services are checked more frequently.
    • Probe sweeps include only locally available services backed by containers.
  • Documentation
    • Updated protocol guidance to clarify compatibility expectations and the role of heartbeat messages.

Brings cloud/proto back to byte-identical with the control plane's copy:
the tailnet probe cadence constant (read only by the cloud) takes the
cloud's 120s value, ValidateHTTPPath is exported as it is upstream, and
the doc.go and constant comments are reconciled so they read true in both
repositories. No wire shape changes.
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 00615240-bfcb-43c8-a7a5-cd70aae1e3ea

📥 Commits

Reviewing files that changed from the base of the PR and between 3a88788 and 1950245.

📒 Files selected for processing (5)
  • AGENTS.md
  • cloud/proto/doc.go
  • cloud/proto/messages.go
  • cloud/proto/schema.json
  • cloud/proto/validate.go

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The cloud proto package documentation and synchronization guidance were updated. The tailnet probe interval and HTTP status classification were revised, and HTTP path validation became an exported function.

Changes

Cloud proto updates

Layer / File(s) Summary
Protocol contract and defaults
AGENTS.md, cloud/proto/doc.go, cloud/proto/messages.go, cloud/proto/schema.json
The guidance and package documentation describe the synchronized proto copies and wire constraints. The tailnet probe interval changes to 120,000 milliseconds. The http_status classification is added to the message constant and CheckResult schema enum. Message comments are also revised.
Export HTTP path validation
cloud/proto/validate.go
validateHTTPPath is renamed to the exported ValidateHTTPPath, and ValidateCheckConfig calls the exported function. The validation logic is unchanged.

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: ⚪ Minimal · up to 19502

No actionable issue is established in the supplied changes. Confirm the control-plane copy is synchronized as part of the normal release checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: re-synchronizing the cloud protocol copy with the cloud source of truth.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The control plane's copy gained ClassHTTPStatus; mirror the identical
lines so this copy stays byte-identical with it.
…t root

Newer golangci-lint ships gosec's taint-based G703, which flags the
DOCKTAIL_HOST_ROOT stat in resolveHostRoot. The path is operator-configured
on purpose and only stat-ed, so this is not a traversal.
@marvinvr
marvinvr merged commit 132bcfc into main Sep 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant