Conversation
Brings cloud/proto back to byte-identical with the control plane's copy: the tailnet probe cadence constant (read only by the cloud) takes the cloud's 120s value, ValidateHTTPPath is exported as it is upstream, and the doc.go and constant comments are reconciled so they read true in both repositories. No wire shape changes.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe cloud proto package documentation and synchronization guidance were updated. The tailnet probe interval and HTTP status classification were revised, and HTTP path validation became an exported function. ChangesCloud proto updates
Estimated code review effort: 2 (Simple) | ~12 minutes Merge Risk: ⚪ Minimal · up to No actionable issue is established in the supplied changes. Confirm the control-plane copy is synchronized as part of the normal release checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The control plane's copy gained ClassHTTPStatus; mirror the identical lines so this copy stays byte-identical with it.
…t root Newer golangci-lint ships gosec's taint-based G703, which flags the DOCKTAIL_HOST_ROOT stat in resolveHostRoot. The path is operator-configured on purpose and only stat-ed, so this is not a traversal.
Brings
cloud/protoback to byte-identical with the DockTail Cloud control plane's copy of the wire contract, which had drifted:DefaultTailnetProbeIntervalMStakes the control plane's value (120_000). The agent never reads it — it is the cloud's own polling cadence; the agent-enforced floor (MinTailnetProbeIntervalMS) is unchanged.ValidateHTTPPathis exported, as it is in the upstream copy. No agent code referenced the unexported name.doc.goand theService.Key/LogModeIncident/LogModeOff/ public-vantage comments are reconciled so the same file reads true in both repositories (e.g.LogModeOffis also the fail-closed valueSafeLogModereturns for an empty, invalid or reserved mode).AGENTS.mdnotes thatcloud/protois a verbatim copy that must only change in lockstep with the control plane's.Also carries the new
http_statuscheck class (identical to the lines in fix(cloud): let slow HTTP checks degrade and classify status mismatches correctly #90, so the two PRs merge cleanly in either order).No existing wire shapes, field names or agent behaviour change.
Refs marvinvr/docktail-cloud#38
Summary by CodeRabbit