Skip to content

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Jan 21, 2026

Per earlier team discussion regarding maintenance of outlying packages. This pulls in the (hopefully) minimum dependencies needed from robocrys and matminer (authorship noted in emmet.core.featurization.__init__) needed to not obstruct development in emmet / MP stack

To-do's:
- Porting over tests where needed

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 91.97482% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.41%. Comparing base (4f96ff5) to head (795d309).

Files with missing lines Patch % Lines
...t/core/featurization/robocrys/condense/molecule.py 33.33% 40 Missing ⚠️
emmet-core/emmet/core/featurization/featurizers.py 82.51% 25 Missing ⚠️
.../core/featurization/robocrys/describe/describer.py 92.51% 22 Missing ⚠️
.../core/featurization/robocrys/condense/condenser.py 95.18% 4 Missing ⚠️
...et/core/featurization/robocrys/condense/mineral.py 95.55% 4 Missing ⚠️
.../core/featurization/robocrys/condense/component.py 98.18% 3 Missing ⚠️
...-core/emmet/core/featurization/robocrys/adapter.py 97.87% 1 Missing ⚠️
...ore/featurization/robocrys/condense/fingerprint.py 95.83% 1 Missing ⚠️
...emmet/core/featurization/robocrys/condense/site.py 99.47% 1 Missing ⚠️
...met-core/emmet/core/featurization/robocrys/util.py 98.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1379      +/-   ##
===========================================
+ Coverage    86.01%   86.41%   +0.40%     
===========================================
  Files          229      242      +13     
  Lines        17900    19156    +1256     
===========================================
+ Hits         15397    16554    +1157     
- Misses        2503     2602      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants