fix: add acceptance verifier registry - #14
Closed
matthias-scale wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Closing as superseded. The keyboard fix this PR describes is already on The branch's remaining QA files are older than current base; checking them out would delete 159 lines of since-evolved script. The one piece that was still undelivered, the acceptance verifier registry, is revived against current base in #51. Branch is left intact. |
matthias-scale
added a commit
that referenced
this pull request
Aug 11, 2026
Names `check (ubuntu-latest)` as herdr's trusted acceptance verifier so /amerge can bind a Deep+ ci_surface to a real check instead of guessing from the rollup. The test pins the registry contents and asserts the three ci.yml facts it depends on, so a workflow rename breaks the test rather than silently voiding the mapping. Revives the only undelivered content of #14; that branch's keyboard fix is already on fork/pr-base and its other QA files are older than base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bootstrap the base-owned strict acceptance-verifier allowlist required before Protected admission can verify PR #13. The canonical schema permits only verifier IDs and exact trusted CI check names; it intentionally does not carry PR-authored commands or acceptance clauses.
herdr-check-ubunturesolves to the existing GitHub Actionscheck (ubuntu-latest)job. That job runsjust ci, covering Herdr Rust tests, integration assets, and repository maintenance tests. A subsequent typed contract can independently bind AC1 through AC12—including the session-scoped final-paragraph title behavior in AC12—to this base-owned verifier and receive one exact-head evidence record per clause.Validation
python3 -m unittest scripts.test_acceptance_verifier_registry(red before registry, green after)issue-acceptance-criteria.pyloader accepts the committed registry by full SHAjust check-parallel(all lanes passed)No live Herdr, preview, or PR #13 content was modified.