Skip to content

feat(ci): declare the trusted acceptance verifier registry [no-ticket] - #51

Merged
matthias-scale merged 1 commit into
fork/pr-basefrom
feat/qa-acceptance-verifier-registry
Aug 11, 2026
Merged

feat(ci): declare the trusted acceptance verifier registry [no-ticket]#51
matthias-scale merged 1 commit into
fork/pr-basefrom
feat/qa-acceptance-verifier-registry

Conversation

@matthias-scale

Copy link
Copy Markdown
Owner

Summary

Revives the only undelivered content of #14: .github/acceptance-verifiers.json and its test.

#14 was a stale mixed branch. Its stated content — the Ghostty keyboard fix — is already on fork/pr-base (src/pane.rs sends \x1b[>5u\x1b[>4;2m…, src/main.rs uses ime_compatible_keyboard_enhancement_flags()), so nothing of the original author's work is lost by closing it. Its other QA files are older than base — checking them out would have deleted 159 lines of since-evolved script — so only the two genuinely new files are carried here.

What this does

Names check (ubuntu-latest) as herdr's trusted acceptance verifier, so /amerge can bind a Deep+ ci_surface to a named check rather than inferring one from the rollup.

Acceptance criteria

  • ✓ Registry declares schema acceptance-verifiers/v1 and exactly one verifier — .github/acceptance-verifiers.json
  • ✓ A workflow rename breaks the test instead of silently voiding the mapping — scripts/test_acceptance_verifier_registry.py asserts name: check (\${{ matrix.os }}), - os: ubuntu-latest, and the just ci run line in ci.yml
  • ✓ Green — python3 -m pytest scripts/test_acceptance_verifier_registry.py -q → 1 passed

Validation

python3 -m pytest scripts/test_acceptance_verifier_registry.py -q
1 passed in 0.01s

Names `check (ubuntu-latest)` as herdr's trusted acceptance verifier so /amerge can bind a Deep+ ci_surface to a real check instead of guessing from the rollup. The test pins the registry contents and asserts the three ci.yml facts it depends on, so a workflow rename breaks the test rather than silently voiding the mapping.

Revives the only undelivered content of #14; that branch's keyboard fix is already on fork/pr-base and its other QA files are older than base.
@matthias-scale
matthias-scale merged commit 30a21c7 into fork/pr-base Aug 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant