chore(deps): bump sharp and wrangler in /worker - #1130
Conversation
Bumps [sharp](https://github.com/lovell/sharp) to 0.35.2 and updates ancestor dependency [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler). These dependencies need to be updated together. Updates `sharp` from 0.34.5 to 0.35.2 - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.34.5...v0.35.2) Updates `wrangler` from 4.90.0 to 4.128.0 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.128.0/packages/wrangler) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.2 dependency-type: indirect - dependency-name: wrangler dependency-version: 4.128.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
tend-agent
left a comment
There was a problem hiding this comment.
test-worker is red: npm ci fails with ERESOLVE before any test runs. wrangler 4.128.0 declares peerOptional @cloudflare/workers-types@^5.20260831.1, and worker/package.json still pins ^4.20240821.0, so npm can't satisfy the tree. Dependabot moved wrangler without moving the peer, so both this PR and #1131 fail identically.
The bump itself reads clean: sharp is dev-only and transitive (it arrives via miniflare, which arrives via wrangler), nothing ships in the deployed bundle, and worker/package.json's existing engines.node: >=22.0.0 still matches wrangler's requirement — test-worker already runs on Node 22. Holding APPROVE only because the check is red.
I'm pushing the fix: @cloudflare/workers-types to ^5.20260902.1 (npm's latest, inside wrangler's peer range), with the lockfile regenerated under npm 11 so the libc metadata Dependabot wrote stays intact — npm 10 strips those fields and churns ~90 lines. Verified locally: npm ci exits 0, npm run typecheck is clean under the v5 types with no source changes, all 32 vitest tests pass, and wrangler deploy --dry-run builds the bundle and resolves all three bindings, which is the post-merge path CI doesn't otherwise cover.
Two things worth a maintainer's eye:
- #1131 is a byte-identical change. Both PRs make the same one-line
worker/package.jsonedit and the same lockfile diff; they differ only in which transitive dependency Dependabot named in the commit message (sharphere,undicithere). One can be closed as a duplicate — whichever loses, Dependabot will rebase away. miniflarecrosses a major into an alpha (4.20260507.1→5.20260831.0-alpha), which is wrangler 4.128.0's own pinned dependency, not a choice this PR makes. It only affectswrangler dev;deployand the test suite don't touch it.
Per this repo's running-tend weekly-bump guidance, an npm major would normally get its own PR, but @cloudflare/workers-types v4 → v5 is a hard prerequisite for installing wrangler 4.128 at all, so it can't be split out from this one.
wrangler 4.128.0 declares peerOptional @cloudflare/workers-types@^5.20260831.1; the repo pinned ^4.20240821.0, so npm ci failed with ERESOLVE. Bump to ^5.20260902.1 (npm latest). typecheck, tests, and wrangler deploy --dry-run all pass unchanged.
Bumps sharp to 0.35.2 and updates ancestor dependency wrangler. These dependencies need to be updated together.
Updates
sharpfrom 0.34.5 to 0.35.2Release notes
Sourced from sharp's releases.
... (truncated)
Commits
c9622a3Release v0.35.2cd4568fUpgrade to sharp-libvips v1.3.178390cfTests: Add font file to prevent font discovery flakiness (#4550)61210b4Verify convolve kernel values are numbers (#4549)1cb27dcPrerelease v0.35.2-rc.2c7606c3Upgrade to sharp-libvips v1.3.1-rc.029d1e9ePrerelease v0.35.2-rc.1bbba0a1Improve code bundler support with stub binariesab52866Bound dilate and erode width to avoid mask-size overflow (#4548)0f594ddPrerelease v0.35.2-rc.0Updates
wranglerfrom 4.90.0 to 4.128.0Release notes
Sourced from wrangler's releases.
... (truncated)
Commits
b7b4ff8Version Packages (#15450)ea28cc3[wrangler] Add observability query string redaction (#15379)1809c5e[wrangler] Stop publishing build metafile (#15398)10d6bfbSupport partial manifests in build output (#15388)dbbb795Move binding utilities into workers-utils (#15454)b3f2628[wrangler] Preserve tree-shaking across workspace package boundaries (#15406)b3fb2bffix(wrangler): do not query the GitHub skills API when telemetry is disabled ...87a7acf[wrangler] Add date filters to workflows instances list (#15353)707cb6f[wrangler] Add bundle sizes to structured output (#14915)f808554Version Packages (#15385)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.