chore(deps): bump undici and wrangler in /worker - #1131
Conversation
Bumps [undici](https://github.com/nodejs/undici) to 7.29.0 and updates ancestor dependency [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler). These dependencies need to be updated together. Updates `undici` from 7.24.8 to 7.29.0 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.24.8...v7.29.0) Updates `wrangler` from 4.90.0 to 4.128.0 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.128.0/packages/wrangler) --- updated-dependencies: - dependency-name: undici dependency-version: 7.29.0 dependency-type: indirect - dependency-name: wrangler dependency-version: 4.128.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
tend-agent
left a comment
There was a problem hiding this comment.
Diff is a correct, mechanical security bump: undici 7.24.8 → 7.29.0 (the GHSA-4cwx-7wf7-3272 / GHSA-jr45-8vmc-qm54 cache-control and cookie advisories) pulled through wrangler ^4.90.0 → ^4.128.0, with the rest of the lockfile churn — workerd, miniflare, esbuild, sharp — being wrangler's own pinned dependency set. The only source-level change is the one wrangler range line in worker/package.json. Holding APPROVE because test-worker is red.
The failure is not transient: npm ci aborts with ERESOLVE because wrangler@4.128.0 declares peerOptional @cloudflare/workers-types@"^5.20260831.1" while worker/package.json still pins ^4.20240821.0. Dependabot can't see that constraint from the undici advisory it was chasing, so the companion bump has to come from us. I'm pushing it to this branch: @cloudflare/workers-types → ^5.20260831.1, lockfile regenerated with npm 11 so the libc metadata Dependabot's lock carries survives. Verified locally on Node 22 (the version test-worker uses): npm ci clean, npm run typecheck clean, 32/32 vitest tests pass. Pinning wrangler back or adding --legacy-peer-deps to CI would keep the vulnerable undici or hide the constraint, so neither is a real alternative.
Two notes that need no action here. #1130 ("bump sharp and wrangler in /worker") has a byte-identical diff to this one — same two files, same 332/294 lines — because both advisories resolve through the same wrangler bump; merging either makes the other redundant, and Dependabot will close the loser. And wrangler@4.128.0 depends on miniflare@5.20260831.0-alpha; the prerelease is upstream's own pin inside a stable wrangler release, and it only affects wrangler dev locally, not the deployed Worker.
wrangler 4.128.0 declares `peerOptional @cloudflare/workers-types@"^5.20260831.1"`, so `npm ci` aborted with ERESOLVE against the existing `^4.20240821.0` pin and `test-worker` never got past install. Move the range to the version wrangler asks for; typecheck and the worker suite pass unchanged on Node 22.
Bumps undici to 7.29.0 and updates ancestor dependency wrangler. These dependencies need to be updated together.
Updates
undicifrom 7.24.8 to 7.29.0Release notes
Sourced from undici's releases.
... (truncated)
Commits
9e38fc1Bumped v7.29.0 (#5590)d887e34fix: validate coerced header values for CRLF (#5579)33928bcfix: validate blob body content type98011a8fix(cache): harden cache directive parsing4a9dafbtest(retry): correct broken content-range fixtures in retry-handler.js1b5a531fix(retry): reject partial content length mismatch466e99dtest: cover crash on mixed unqualified and qualified private cache directives9f10f1efix: handle empty qualified private cache directive3bf91ddfix: harden cookie domain, path, and unparsed attribute validationf9eba0aBumped v7.28.0 (#5430)Updates
wranglerfrom 4.90.0 to 4.128.0Release notes
Sourced from wrangler's releases.
... (truncated)
Commits
b7b4ff8Version Packages (#15450)ea28cc3[wrangler] Add observability query string redaction (#15379)1809c5e[wrangler] Stop publishing build metafile (#15398)10d6bfbSupport partial manifests in build output (#15388)dbbb795Move binding utilities into workers-utils (#15454)b3f2628[wrangler] Preserve tree-shaking across workspace package boundaries (#15406)b3fb2bffix(wrangler): do not query the GitHub skills API when telemetry is disabled ...87a7acf[wrangler] Add date filters to workflows instances list (#15353)707cb6f[wrangler] Add bundle sizes to structured output (#14915)f808554Version Packages (#15385)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.