feat(glides): add automatic start and end times#19
Conversation
| - `automaticStartTime` ([Time](#time) | "unset", optional): if present, the new time that the train's departure from `startLocation` (or the existing `startLocation` of the trip) was detected. | ||
| - `automaticEndTime` ([Time](#time) | "unset", optional): if present, the new time that the train's arrival at `endLocation` (or the existing `endLocation` of the trip) was detected. |
There was a problem hiding this comment.
Can you add the interpretation if not present or unset?
There was a problem hiding this comment.
@runkelcorey to clarify, by "interpretation" do you mean ([Time](#time) | "unset", optional)? Or expanding the explanation of the field to include not present and unset?
There was a problem hiding this comment.
the latter! I'd like the docs to clarify what the user should think if a value is not present or unset
| The partition key will be a hash of the station at which the inspector is working and the inspector's identity, which ensures that multiple events from a single inspector are ordered correctly if the records are distributed across multiple shards. | ||
| The partition key will be either: | ||
| - a hash of the station at which the inspector is working and the inspector's identity, which ensures that multiple events from a single inspector are ordered correctly if the records are distributed across multiple shards. | ||
| - a hash of a string constant if the automatic time was recorded by the `AutomaticTripTimeRecorder` process in Glides. |
There was a problem hiding this comment.
question: I know we talked about this, and I think this is probably reasonable? But wondering if we need to check with more folks downstream (maybe even with Ops Analytics?) to ensure that nothing is tightly coupled to the existing semantics of the partition key.
There was a problem hiding this comment.
I doubt anyone would be relying on this, and if they are we'll hear about some strangely prolific, teleporting inspector.
4 participants
Asana Ticket: Add automatic times to Glides events -> LAMP
LMK anything that is missing that is usually expected from updates to this repo.
See accompanying Glides PR for the implementation of this proposal. (I will wait for feedback and approval on the schema change here before merging that.)
Adds
automaticStartTimeandautomaticEndTimefields to Glides eventsTripUpdateddata. This is expected to be a non-breaking change.