add check to ensure CLIP is embedded before saving to prevent crash during LoRA extraction#1343
Merged
mcmonkey4eva merged 1 commit intomcmonkeyprojects:masterfrom Apr 13, 2026
Conversation
…uring LoRA extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1330
This provides a safeguard in the Python code to ensure
base_model_clipandother_model_clipare set before extracting the embedded CLIP.Flux Checkpoints in the
Stable-Diffusiondirectory are treated as regular checkpoints, and the check fordoClipis based on the directory structure:It seems like a long term goal would be to check whether or not checkpoints in the
Stable-Diffusiondirectory contain an embedded text encoder, and what that text encoder is (like CLIP or T5). As far as I know that is not reliably present in checkpoint metadata.