Skip to content

add check to ensure CLIP is embedded before saving to prevent crash during LoRA extraction #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmonkey4eva merged 1 commit into from
Apr 13, 2026
Merged

add check to ensure CLIP is embedded before saving to prevent crash during LoRA extraction #1343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/BuiltinExtensions/ComfyUIBackend/ExtraNodes/SwarmComfyCommon/SwarmExtractLora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,11 @@ def extract_lora(self, base_model, base_model_clip, other_model, other_model_cli
other_data = other_model.model_state_dict()
key_count = len(base_data.keys())
if save_clip:
key_count += len(base_model_clip.get_sd().keys())
if base_model_clip is None or other_model_clip is None:
print("Warning: save_clip is True but CLIP model(s) are unavailable (model may not have embedded CLIP, e.g. Flux), skipping CLIP extraction")
save_clip = False
else:
key_count += len(base_model_clip.get_sd().keys())
pbar = comfy.utils.ProgressBar(key_count)
class Helper:
steps = 0
Expand Down
Loading