feat(config)!: remove legacy CLAUDE_ON_INCUS_* env-var config overrides#537
Merged
Conversation
CLAUDE_ON_INCUS_IMAGE, _PERSISTENT, _SESSIONS_DIR, and _STORAGE_DIR were first-commit relics from the pre-rename claude-on-incus era that silently overrode config (a stray CLAUDE_ON_INCUS_PERSISTENT=true in a shell profile could defeat explicit config). Removed entirely, no shim: config-shaped settings live in config/profiles ([container] image / persistent, [paths] sessions_dir / storage_dir). COI_LIMIT_* stays as the one remaining env layer; the claude-on-incus binary symlink compatibility is untouched. README config-precedence section rewritten to the config-first model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last pre-rename relics: the
CLAUDE_ON_INCUS_IMAGE,CLAUDE_ON_INCUS_PERSISTENT,CLAUDE_ON_INCUS_SESSIONS_DIR, andCLAUDE_ON_INCUS_STORAGE_DIRenv vars, which dated to the initial claude-on-incus commit and silently overrode config (a strayCLAUDE_ON_INCUS_PERSISTENT=truein a shell profile could defeat explicit config — including the 0.10 persistence semantics).Per the config-first model, they're removed entirely, no shim: the replacements are the config keys that already exist (
[container] image/persistent,[paths] sessions_dir/storage_dir), settable globally, per project, or per profile.loadFromEnvnow handles onlyCOI_LIMIT_*(the one remaining, deliberately kept env layer).TestLoadFromEnvrewritten to cover the COI_LIMIT layer; no test references the legacy vars anymore.$COI_CONFIG) → project config → profile; config-shaped settings have no flags or env overrides.claude-on-incusbinary/symlink compatibility untouched (real users have old installs).Gates: go build/vet/test, golangci-lint v2.12.2 (0 issues), gofmt — green. Rides the unreleased 0.10.0 breaking umbrella.