Skip to content

Refactor: Move inline imports to top of file (AGENTS.md)#2

Closed
Copilot wants to merge 2 commits intosolving-christmas-lights-kata-with-copilotfrom
copilot/sub-pr-1
Closed

Refactor: Move inline imports to top of file (AGENTS.md)#2
Copilot wants to merge 2 commits intosolving-christmas-lights-kata-with-copilotfrom
copilot/sub-pr-1

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 4, 2025

Addresses code review feedback about inline imports in test_controller.py violating AGENTS.md guidelines.

Changes

  • Moved subprocess and os imports from inline within test functions to the top of the file

Before:

import sys
import pytest
from python.christmas_lights_kata.src import controller

def test_main_with_invalid_instruction(tmp_path):
    import subprocess
    import os
    # ...

After:

import os
import subprocess
import sys

import pytest

from python.christmas_lights_kata.src import controller

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: micaelarp <50937937+micaelarp@users.noreply.github.com>
Copilot AI changed the title [WIP] Update christmas lights kata implementation based on feedback Refactor: Move inline imports to top of file (AGENTS.md) Dec 4, 2025
Copilot AI requested a review from micaelarp December 4, 2025 11:38
@micaelarp micaelarp closed this Dec 4, 2025
@micaelarp micaelarp deleted the copilot/sub-pr-1 branch December 15, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants