Skip to content

Refactor: Move inline imports to top of file (AGENTS.md) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Refactor: Move inline imports to top of file (AGENTS.md) #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a4e3b
Initial plan
Copilot Dec 4, 2025
f20381c
Refactor: Move subprocess and os imports to top of file (AGENTS.md)
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions python/christmas_lights_kata/tests/test_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import os
import subprocess
import sys

import pytest

from python.christmas_lights_kata.src import controller


Expand All @@ -22,8 +26,6 @@ def test_main_runs_and_reports_lit_lights(tmp_path, capsys):

def test_main_with_invalid_instruction(tmp_path):
"""Should print error and exit for invalid instructions (robust subprocess test)."""
import subprocess
import os
instr = "invalid command"
instr_path = tmp_path / "instr.md"
instr_path.write_text(instr)
Expand All @@ -43,7 +45,6 @@ def test_main_with_empty_file(tmp_path):
"""Should report zero lights lit for empty instruction file."""
instr_path = tmp_path / "instr.md"
instr_path.write_text("")
import subprocess, os
env = os.environ.copy()
env["PYTHONPATH"] = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../.."))
result = subprocess.run([
Expand All @@ -60,7 +61,6 @@ def test_main_with_only_comments(tmp_path):
"""Should report zero lights lit for file with only comments."""
instr_path = tmp_path / "instr.md"
instr_path.write_text("# comment\n# another comment")
import subprocess, os
env = os.environ.copy()
env["PYTHONPATH"] = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../.."))
result = subprocess.run([
Expand All @@ -78,7 +78,6 @@ def test_main_with_extra_spaces(tmp_path):
instr = " turn on 0,0 through 0,0 "
instr_path = tmp_path / "instr.md"
instr_path.write_text(instr)
import subprocess, os
env = os.environ.copy()
env["PYTHONPATH"] = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../.."))
result = subprocess.run([
Expand All @@ -96,7 +95,6 @@ def test_main_with_out_of_bounds(tmp_path):
instr = "turn on -1,0 through 0,0"
instr_path = tmp_path / "instr.md"
instr_path.write_text(instr)
import subprocess, os
env = os.environ.copy()
env["PYTHONPATH"] = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../.."))
result = subprocess.run([
Expand Down