Skip to content

http-client-java, access=public would override paged#10131

Merged
weidongxu-microsoft merged 11 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_bug-fix-paged-model
Mar 26, 2026
Merged

http-client-java, access=public would override paged#10131
weidongxu-microsoft merged 11 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_bug-fix-paged-model

Conversation

@weidongxu-microsoft
Copy link
Copy Markdown
Contributor

@weidongxu-microsoft weidongxu-microsoft commented Mar 25, 2026

A workaround for Paged model used in request or referenced by other public model.
Hack to kusto would to put access=public on that paged model used as request body.

This use case is rare.

Downstream is good.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

All changed packages have been documented.

  • @typespec/http-client-java
Show changes

@typespec/http-client-java - dependencies ✏️

Update Node dependencies

@typespec/http-client-java - fix ✏️

access=public should override Paged

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Mar 25, 2026

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Comment thread packages/http-client-java/emitter/src/code-model-builder.ts
@weidongxu-microsoft weidongxu-microsoft added this pull request to the merge queue Mar 26, 2026
Merged via the queue into microsoft:main with commit c1cc310 Mar 26, 2026
32 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the http-client-java_bug-fix-paged-model branch March 26, 2026 06:37
msyyc pushed a commit that referenced this pull request Apr 1, 2026
A workaround for Paged model used in request or referenced by other
public model.
Hack to kusto would to put `access=public` on that paged model used as
request body.

This use case is rare.

Downstream is good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:java Issue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants