-
Notifications
You must be signed in to change notification settings - Fork 371
http-client-java, access=public would override paged #10131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weidongxu-microsoft
merged 11 commits into
microsoft:main
from
weidongxu-microsoft:http-client-java_bug-fix-paged-model
Mar 26, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
adc85a6
remove older-version
weidongxu-microsoft e9716f1
bump dependency
weidongxu-microsoft 798ddc8
regen
weidongxu-microsoft 8851122
handle Paged similar to Spread
weidongxu-microsoft e3b1e57
add test
weidongxu-microsoft dc63040
revert logic
weidongxu-microsoft c15b6c4
let access=public override paged
weidongxu-microsoft 2042b8d
regen
weidongxu-microsoft c558955
test
weidongxu-microsoft 73eff0d
changelog
weidongxu-microsoft efe0e89
update node.js and regen
weidongxu-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.chronus/changes/http-client-java_bug-fix-paged-model-2026-2-24-16-23-15.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: dependencies | ||
| packages: | ||
| - "@typespec/http-client-java" | ||
| --- | ||
|
|
||
| Update Node dependencies |
7 changes: 7 additions & 0 deletions
7
.chronus/changes/http-client-java_bug-fix-paged-model-2026-2-25-16-16-24.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: fix | ||
| packages: | ||
| - "@typespec/http-client-java" | ||
| --- | ||
|
|
||
| access=public should override Paged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
...test/src/main/java/payload/pageable/ServerDrivenPaginationAlternateInitialVerbClient.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package payload.pageable; | ||
|
|
||
| import io.clientcore.core.annotations.Metadata; | ||
| import io.clientcore.core.annotations.MetadataProperties; | ||
| import io.clientcore.core.annotations.ReturnType; | ||
| import io.clientcore.core.annotations.ServiceClient; | ||
| import io.clientcore.core.annotations.ServiceMethod; | ||
| import io.clientcore.core.http.models.HttpResponseException; | ||
| import io.clientcore.core.http.models.RequestContext; | ||
| import io.clientcore.core.http.paging.PagedIterable; | ||
| import io.clientcore.core.instrumentation.Instrumentation; | ||
| import payload.pageable.implementation.ServerDrivenPaginationAlternateInitialVerbsImpl; | ||
| import payload.pageable.serverdrivenpagination.alternateinitialverb.Filter; | ||
|
|
||
| /** | ||
| * Initializes a new instance of the synchronous PageableClient type. | ||
| */ | ||
| @ServiceClient(builder = PageableClientBuilder.class) | ||
| public final class ServerDrivenPaginationAlternateInitialVerbClient { | ||
| @Metadata(properties = { MetadataProperties.GENERATED }) | ||
| private final ServerDrivenPaginationAlternateInitialVerbsImpl serviceClient; | ||
|
|
||
| private final Instrumentation instrumentation; | ||
|
|
||
| /** | ||
| * Initializes an instance of ServerDrivenPaginationAlternateInitialVerbClient class. | ||
| * | ||
| * @param serviceClient the service client implementation. | ||
| * @param instrumentation the instrumentation instance. | ||
| */ | ||
| @Metadata(properties = { MetadataProperties.GENERATED }) | ||
| ServerDrivenPaginationAlternateInitialVerbClient(ServerDrivenPaginationAlternateInitialVerbsImpl serviceClient, | ||
| Instrumentation instrumentation) { | ||
| this.serviceClient = serviceClient; | ||
| this.instrumentation = instrumentation; | ||
| } | ||
|
|
||
| /** | ||
| * The post operation. | ||
| * | ||
| * @param body The body parameter. | ||
| * @throws IllegalArgumentException thrown if parameters fail the validation. | ||
| * @throws HttpResponseException thrown if the service returns an error. | ||
| * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent. | ||
| * @return the paginated response with {@link PagedIterable}. | ||
| */ | ||
| @Metadata(properties = { MetadataProperties.GENERATED }) | ||
| @ServiceMethod(returns = ReturnType.COLLECTION) | ||
| public PagedIterable<Pet> post(Filter body) { | ||
| return post(body, RequestContext.none()); | ||
| } | ||
|
|
||
| /** | ||
| * The post operation. | ||
| * | ||
| * @param body The body parameter. | ||
| * @param requestContext The context to configure the HTTP request before HTTP client sends it. | ||
| * @throws IllegalArgumentException thrown if parameters fail the validation. | ||
| * @throws HttpResponseException thrown if the service returns an error. | ||
| * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent. | ||
| * @return the paginated response with {@link PagedIterable}. | ||
| */ | ||
| @Metadata(properties = { MetadataProperties.GENERATED }) | ||
| @ServiceMethod(returns = ReturnType.COLLECTION) | ||
| public PagedIterable<Pet> post(Filter body, RequestContext requestContext) { | ||
| return this.serviceClient.post(body, requestContext); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.