Conversation
The worklet stamps a MIDI message with the time its frame sounds and posts it as it composes. At the page's default delay of 0, one that reaches the page a few milliseconds late is past due and goes out stamped now; headless audio has almost no output latency to absorb that, so on a loaded CI runner the clock check measured ticks 46 ms apart where 41.7 was due (master's #337 merge and several PRs), and a half-beat note once came out at 479 ms. The MIDI out block now runs at a 100 ms delay, which is what the setting is for; the delayed-note check keeps its 200, and the delay goes back to 0 at the end. The half-beat note now measures 500.0 ms exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
MIDI clock goes outcheck inpagetest.mjs, which failed master's CI after #337 merged ("28 ticks 46.1 ms apart") and blocked that deploy. It had failed the same way on several PRs.Cause
handOffthen sends it stampednow, i.e.Math.max(due, now).Change
Testing
pagetest.mjs, 3 runs: the half-beat note now measures 500.0 ms exactly (it was 490–492 locally before), beat spacing is 1002.6–1002.8 ms, and the clock is 41.7 ms apart every time.