Skip to content

web: time the MIDI out checks with a delay #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mishan merged 1 commit into from
Oct 4, 2026
Merged

web: time the MIDI out checks with a delay #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion wasm/web/pagetest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,6 +2455,15 @@ try
check(await page.$eval('#midioutstatus', (e) => e.textContent) ===
'Fake Synth', 'and the status names the output');

/* Timed with some delay, as anyone sending to a device sets it.
The worklet stamps a message with the time its frame sounds and
posts it as it composes; at a delay of 0 one that crosses to the
page a few milliseconds late is past due when it lands and goes
out stamped `now'. Headless audio has next to no output latency
to absorb that, so on a loaded runner the times measured below
would be the page's arrival times rather than the piece's. */
await page.fill('#midioutdelay', '100');
await page.dispatchEvent('#midioutdelay', 'change');
await page.evaluate(() => { window.midiSent.length = 0; });
await page.click('#play');
await page.waitForTimeout(2600);
Expand Down Expand Up @@ -2525,7 +2534,7 @@ try
`a delayed note waits in the page until shortly before its ` +
`time: handed over ${lead.toFixed(1)} ms ahead`);

await page.fill('#midioutdelay', '0');
await page.fill('#midioutdelay', '100');
await page.dispatchEvent('#midioutdelay', 'change');

await page.selectOption('select.midiroute', '@synth');
Expand Down Expand Up @@ -2564,6 +2573,8 @@ try
`MIDI clock goes out: Start, ${ticks.length} ticks ` +
`${gap.toFixed(1)} ms apart, Stop`);

await page.fill('#midioutdelay', '0');
await page.dispatchEvent('#midioutdelay', 'change');
await page.$eval('input.midiclock', (e) => e.click());
await page.evaluate(() =>
{
Expand Down
Loading