⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs - #230
⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs#230mleem97 wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | -1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Superseded by consolidated integration PR #235. The reviewed security/performance changes are documented in docs/maintainers/open-pr-audit-2026-08.md. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What: Replaced expensive
UnityEngine.Object.FindObjectsOfType<T>()calls with O(1) dictionary lookups fromIl2Cpp.NetworkMap.instanceinLuaServerModule.cs(get_all,repair,repair_all).🎯 Why:
FindObjectsOfType<T>is O(N) and traverses the entire Unity object hierarchy, causing significant CPU overhead and GC pressure.📊 Impact: Substantially reduces CPU usage and hitching during Lua script polling, scaling correctly in late-game scenarios.
🔬 Measurement: Profile the execution time of Lua script loops polling
server.get_all()/server.repair_all().PR created automatically by Jules for task 2369615359657136189 started by @mleem97