Skip to content

⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mleem97 wants to merge 2 commits into from
Closed

⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c17da
⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs
mleem97 Aug 10, 2026
a837cda
⚡ Bolt: Optimize Expensive FindObjectsOfType Calls in Lua APIs
mleem97 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 56 additions & 2 deletions src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
var result = new Table(script);
int i = 1;
foreach (var s in servers)

Action<Il2Cpp.Server> addServer = (s) =>
{
if (s == null) return;
try
{
var info = new Table(script);
Expand All @@ -42,7 +43,22 @@ public static void Register(Table greg, Script script, string modId)
result[i++] = info;
}
catch { }
};

// Optimization: Use O(1) lookup from game-managed NetworkMap instead of O(N) FindObjectsOfType
var nm = Il2Cpp.NetworkMap.instance;
if (nm != null && nm.servers != null)
{
foreach (var kvp in nm.servers)
{
addServer(kvp.Value);
}
return result;
}

var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers) addServer(s);

return result;
}
catch (Exception ex)
Expand Down Expand Up @@ -80,6 +96,21 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var nm = Il2Cpp.NetworkMap.instance;
if (nm != null && nm.brokenServers != null)
{
foreach (var kvp in nm.brokenServers)
{
var s = kvp.Value;
if (s != null && s.GetHashCode() == hash && s.isBroken)
{
s.RepairDevice();
return true;
}
}
return false;
}

var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers)
{
Expand All @@ -104,6 +135,29 @@ public static void Register(Table greg, Script script, string modId)
try
{
int repaired = 0;
var nm = Il2Cpp.NetworkMap.instance;
if (nm != null && nm.brokenServers != null)
{
if (nm.brokenServers.Count == 0) return 0;

var keys = new System.Collections.Generic.List<string>();
foreach (var kvp in nm.brokenServers) keys.Add(kvp.Key);

foreach (var key in keys)
{
try
{
if (nm.brokenServers.TryGetValue(key, out var s) && s != null && s.isBroken)
{
s.RepairDevice();
repaired++;
}
}
catch { }
}
return repaired;
}

var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers)
{
Expand Down
Loading